Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935402AbdGTIyA (ORCPT ); Thu, 20 Jul 2017 04:54:00 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:34216 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934728AbdGTIx4 (ORCPT ); Thu, 20 Jul 2017 04:53:56 -0400 Date: Thu, 20 Jul 2017 09:53:53 +0100 From: Lee Jones To: Guodong Xu Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 2/3] mfd: hi6421-pmic: cleanup: update dev_err messages Message-ID: <20170720085353.xhy3oldf755fxw46@dell> References: <20170720073242.1758-1-guodong.xu@linaro.org> <20170720073242.1758-3-guodong.xu@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170720073242.1758-3-guodong.xu@linaro.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 42 On Thu, 20 Jul 2017, Guodong Xu wrote: > Update dev_err messages to make them more readable. > > Signed-off-by: Guodong Xu > Acked-by: Arnd Bergmann > --- > drivers/mfd/hi6421-pmic-core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c > index ad9e3d8..b1139d4 100644 > --- a/drivers/mfd/hi6421-pmic-core.c > +++ b/drivers/mfd/hi6421-pmic-core.c > @@ -52,8 +52,8 @@ static int hi6421_pmic_probe(struct platform_device *pdev) > pmic->regmap = devm_regmap_init_mmio_clk(&pdev->dev, NULL, base, > &hi6421_regmap_config); > if (IS_ERR(pmic->regmap)) { > - dev_err(&pdev->dev, > - "regmap init failed: %ld\n", PTR_ERR(pmic->regmap)); > + dev_err(&pdev->dev, "Failed to initialise Regmap: %ld\n", > + PTR_ERR(pmic->regmap)); > return PTR_ERR(pmic->regmap); > } > > @@ -70,7 +70,7 @@ static int hi6421_pmic_probe(struct platform_device *pdev) > ret = devm_mfd_add_devices(&pdev->dev, 0, hi6421_devs, > ARRAY_SIZE(hi6421_devs), NULL, 0, NULL); > if (ret) { > - dev_err(&pdev->dev, "add mfd devices failed: %d\n", ret); > + dev_err(&pdev->dev, "Failed to add child devices: %d\n", ret); > return ret; > } > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog