Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935579AbdGTJBu (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Jul 2017 05:01:50 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:35194 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933932AbdGTJBo (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Jul 2017 05:01:44 -0400
Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures.
To: Borislav Petkov <bp@alien8.de>
References: <1500535305-9369-1-git-send-email-arvind.yadav.cs@gmail.com>
 <1500535305-9369-8-git-send-email-arvind.yadav.cs@gmail.com>
 <20170720081207.GA18424@nazgul.tnic>
 <27e82108-10c3-a411-d6ad-c399b603db82@gmail.com>
 <20170720082850.GB18424@nazgul.tnic>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        tony.luck@intel.com, linux-kernel@vger.kernel.org
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Message-ID: <3e870042-56ec-8b12-98e7-2110c7b75ac5@gmail.com>
Date: Thu, 20 Jul 2017 14:31:09 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20170720082850.GB18424@nazgul.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1149
Lines: 38

Hi,


On Thursday 20 July 2017 01:58 PM, Borislav Petkov wrote:
> On Thu, Jul 20, 2017 at 01:48:17PM +0530, Arvind Yadav wrote:
>> It's just show, how much bytes move from data segment to text segment.
>> ~arvind
>       3614	    545	   1560	   5719	   1657	x86/kernel/cpu/microcode/core.o
>
> 3614 + 545 = 4159
>
>       3742	    417	   1560	   5719	   1657	x86/kernel/cpu/microcode/core.o
>
> 3742 + 417 = 4159
>
> 3742 - 3614 = 128
>
> So 128 bytes moved to text.
Yes,
>
> I fail to see how this is relevant. Your commit message contains not
> really relevant info for such a simple change. Rather, it should just be
> a one-liner:
I have mentioned all this in commit message. I have added below
message in patch. Please check my patch.

"attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const."

> "Constify attribute_group structs because they don't change at runtime."
I can add this as subject. But we should avoid lengthy subject.
Even checkpatch.pl will through warning.
>
> That's it.
>
~arvind