Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753627AbdGTJ2j (ORCPT ); Thu, 20 Jul 2017 05:28:39 -0400 Received: from mail-qt0-f172.google.com ([209.85.216.172]:34617 "EHLO mail-qt0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964919AbdGTJ2h (ORCPT ); Thu, 20 Jul 2017 05:28:37 -0400 MIME-Version: 1.0 In-Reply-To: <1500373219-20233-5-git-send-email-philippe.cornu@st.com> References: <1500373219-20233-1-git-send-email-philippe.cornu@st.com> <1500373219-20233-5-git-send-email-philippe.cornu@st.com> From: Benjamin Gaignard Date: Thu, 20 Jul 2017 11:28:36 +0200 Message-ID: Subject: Re: [PATCH v1 4/7] drm/stm: ltdc: Constify funcs structures To: Philippe CORNU Cc: Yannick Fertre , Vincent Abriou , David Airlie , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List , Fabien Dessenne , Mickael Reulier , Gabriel Fernandez , Ludovic Barre , Alexandre Torgue , Maxime Coquelin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6K9Sjs7007797 Content-Length: 1872 Lines: 56 2017-07-18 12:20 GMT+02:00 Philippe CORNU : > Constify drm funcs structures. > > Signed-off-by: Philippe CORNU Reviewed-by: Benjamin Gaignard > --- > drivers/gpu/drm/stm/ltdc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c > index 628825b..92e58ba 100644 > --- a/drivers/gpu/drm/stm/ltdc.c > +++ b/drivers/gpu/drm/stm/ltdc.c > @@ -511,7 +511,7 @@ static void ltdc_crtc_atomic_flush(struct drm_crtc *crtc, > } > } > > -static struct drm_crtc_helper_funcs ltdc_crtc_helper_funcs = { > +static const struct drm_crtc_helper_funcs ltdc_crtc_helper_funcs = { > .load_lut = ltdc_crtc_load_lut, > .mode_set_nofb = ltdc_crtc_mode_set_nofb, > .atomic_flush = ltdc_crtc_atomic_flush, > @@ -537,7 +537,7 @@ void ltdc_crtc_disable_vblank(struct drm_device *ddev, unsigned int pipe) > reg_clear(ldev->regs, LTDC_IER, IER_LIE); > } > > -static struct drm_crtc_funcs ltdc_crtc_funcs = { > +static const struct drm_crtc_funcs ltdc_crtc_funcs = { > .destroy = drm_crtc_cleanup, > .set_config = drm_atomic_helper_set_config, > .page_flip = drm_atomic_helper_page_flip, > @@ -693,7 +693,7 @@ static void ltdc_plane_atomic_disable(struct drm_plane *plane, > oldstate->crtc->base.id, plane->base.id); > } > > -static struct drm_plane_funcs ltdc_plane_funcs = { > +static const struct drm_plane_funcs ltdc_plane_funcs = { > .update_plane = drm_atomic_helper_update_plane, > .disable_plane = drm_atomic_helper_disable_plane, > .destroy = drm_plane_cleanup, > -- > 1.9.1 > -- Benjamin Gaignard Graphic Study Group Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog