Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S964927AbdGTJbj (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Jul 2017 05:31:39 -0400
Received: from mail-qk0-f181.google.com ([209.85.220.181]:38219 "EHLO
        mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S935659AbdGTJbh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Jul 2017 05:31:37 -0400
MIME-Version: 1.0
In-Reply-To: <1500373219-20233-7-git-send-email-philippe.cornu@st.com>
References: <1500373219-20233-1-git-send-email-philippe.cornu@st.com> <1500373219-20233-7-git-send-email-philippe.cornu@st.com>
From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date: Thu, 20 Jul 2017 11:31:36 +0200
Message-ID: <CA+M3ks5Hh_9v_ZpMFL=N_jajKFuSu6CqLmu0jmGq2pwsO4bT8w@mail.gmail.com>
Subject: Re: [PATCH v1 6/7] drm/stm: ltdc: Cleanup rename returned value
To: Philippe CORNU <philippe.cornu@st.com>
Cc: Yannick Fertre <yannick.fertre@st.com>,
        Vincent Abriou <vincent.abriou@st.com>,
        David Airlie <airlied@linux.ie>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Fabien Dessenne <fabien.dessenne@st.com>,
        Mickael Reulier <mickael.reulier@st.com>,
        Gabriel Fernandez <gabriel.fernandez@st.com>,
        Ludovic Barre <ludovic.barre@st.com>,
        Alexandre Torgue <alexandre.torgue@st.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v6K9Vjdh007809
Content-Length: 2129
Lines: 67

2017-07-18 12:20 GMT+02:00 Philippe CORNU <philippe.cornu@st.com>:

Commit message is missing here


> Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
> ---
>  drivers/gpu/drm/stm/ltdc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index f4ed21a..8cd1b9b 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -760,7 +760,7 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
>         struct ltdc_device *ldev = ddev->dev_private;
>         struct drm_plane *primary, *overlay;
>         unsigned int i;
> -       int res;
> +       int ret;
>
>         primary = ltdc_plane_create(ddev, DRM_PLANE_TYPE_PRIMARY);
>         if (!primary) {
> @@ -768,9 +768,9 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
>                 return -EINVAL;
>         }
>
> -       res = drm_crtc_init_with_planes(ddev, crtc, primary, NULL,
> +       ret = drm_crtc_init_with_planes(ddev, crtc, primary, NULL,
>                                         &ltdc_crtc_funcs, NULL);
> -       if (res) {
> +       if (ret) {
>                 DRM_ERROR("Can not initialize CRTC\n");
>                 goto cleanup;
>         }
> @@ -783,7 +783,7 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
>         for (i = 1; i < ldev->caps.nb_layers; i++) {
>                 overlay = ltdc_plane_create(ddev, DRM_PLANE_TYPE_OVERLAY);
>                 if (!overlay) {
> -                       res = -ENOMEM;
> +                       ret = -ENOMEM;
>                         DRM_ERROR("Can not create overlay plane %d\n", i);
>                         goto cleanup;
>                 }
> @@ -793,7 +793,7 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
>
>  cleanup:
>         ltdc_plane_destroy_all(ddev);
> -       return res;
> +       return ret;
>  }
>
>  /*
> --
> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog