Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935845AbdGTKCz (ORCPT ); Thu, 20 Jul 2017 06:02:55 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:34278 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934012AbdGTKCw (ORCPT ); Thu, 20 Jul 2017 06:02:52 -0400 Subject: Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function To: Johan Hovold References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-3-git-send-email-j-keerthy@ti.com> <20170719111000.GX29638@localhost> <20170720095047.GA2729@localhost> CC: , , , , , , , , From: Keerthy Message-ID: <47055927-5102-b39f-fdbb-b5d89cb14632@ti.com> Date: Thu, 20 Jul 2017 15:32:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170720095047.GA2729@localhost> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2071 Lines: 64 On Thursday 20 July 2017 03:20 PM, Johan Hovold wrote: > On Thu, Jul 20, 2017 at 02:40:37PM +0530, Keerthy wrote: >> >> >> On Thursday 20 July 2017 12:14 PM, Keerthy wrote: >>> >>> >>> On Wednesday 19 July 2017 04:40 PM, Johan Hovold wrote: >>>> On Tue, Jul 18, 2017 at 04:27:14PM +0530, Keerthy wrote: >>>>> Currently davinci_gpio_irq_setup return value is ignored. Handle the >>>>> return value appropriately. >>>>> >>>>> Signed-off-by: Keerthy >>>>> --- >>>>> drivers/gpio/gpio-davinci.c | 18 +++++++++++++----- >>>>> 1 file changed, 13 insertions(+), 5 deletions(-) >>>>> >>>>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >>>>> index 2c88054..932f270 100644 >>>>> --- a/drivers/gpio/gpio-davinci.c >>>>> +++ b/drivers/gpio/gpio-davinci.c >>>>> @@ -233,15 +233,23 @@ static int davinci_gpio_probe(struct platform_device *pdev) >>>>> chips->regs[bank] = gpio_base + offset_array[bank]; >>>>> >>>>> ret = devm_gpiochip_add_data(dev, &chips->chip, chips); >>>>> + if (ret) >>>>> + goto err; >>>>> + >>>>> + platform_set_drvdata(pdev, chips); >>>>> + ret = davinci_gpio_irq_setup(pdev); >>>>> if (ret) { >>>>> - ctrl_num = 0; >>>>> - bank_base = 0; >>>>> - return ret; >>>>> + platform_set_drvdata(pdev, NULL); >>>>> + goto err; >>>>> } >>>>> >>>>> - platform_set_drvdata(pdev, chips); >>>>> - davinci_gpio_irq_setup(pdev); >>>>> return 0; >>>> >>>> There's a separate but related bug here too as the clk_prepare_enable() >>>> in davinci_gpio_irq_setup() is never balanced on driver unbind. >>> >>> Yes Johan. I will send that as a separate patch. >> >> This is already fixed in the latest kernel: >> >> commit 6dc0048cff988858254fcc26becfc1e9753efa79 >> Author: Arvind Yadav >> Date: Tue May 23 14:48:57 2017 +0530 > > That change only handles errors in davinci_gpio_irq_setup() (i.e. during > probe) and not the imbalance at driver unbind that I was referring to. Okay got it. One more clk_unprepare_disable() call needs to be there in probe err path. > > Johan >