Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935862AbdGTKFS (ORCPT ); Thu, 20 Jul 2017 06:05:18 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:34207 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933887AbdGTKFP (ORCPT ); Thu, 20 Jul 2017 06:05:15 -0400 Date: Thu, 20 Jul 2017 12:05:09 +0200 From: Johan Hovold To: Keerthy Cc: Johan Hovold , linus.walleij@linaro.org, ssantosh@kernel.org, devicetree@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, fcooper@ti.com Subject: Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function Message-ID: <20170720100509.GB2729@localhost> References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-3-git-send-email-j-keerthy@ti.com> <20170719111000.GX29638@localhost> <20170720095047.GA2729@localhost> <47055927-5102-b39f-fdbb-b5d89cb14632@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47055927-5102-b39f-fdbb-b5d89cb14632@ti.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1056 Lines: 27 On Thu, Jul 20, 2017 at 03:32:27PM +0530, Keerthy wrote: > On Thursday 20 July 2017 03:20 PM, Johan Hovold wrote: > > On Thu, Jul 20, 2017 at 02:40:37PM +0530, Keerthy wrote: > >> On Thursday 20 July 2017 12:14 PM, Keerthy wrote: > >>> On Wednesday 19 July 2017 04:40 PM, Johan Hovold wrote: > >>>> There's a separate but related bug here too as the clk_prepare_enable() > >>>> in davinci_gpio_irq_setup() is never balanced on driver unbind. > >>> > >>> Yes Johan. I will send that as a separate patch. > >> > >> This is already fixed in the latest kernel: > >> > >> commit 6dc0048cff988858254fcc26becfc1e9753efa79 > >> Author: Arvind Yadav > >> Date: Tue May 23 14:48:57 2017 +0530 > > > > That change only handles errors in davinci_gpio_irq_setup() (i.e. during > > probe) and not the imbalance at driver unbind that I was referring to. > > Okay got it. One more clk_unprepare_disable() call needs to be there in > probe err path. No, you need to balance it on driver unbind, that is, in a new remove() callback. Johan