Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965036AbdGTKKA (ORCPT ); Thu, 20 Jul 2017 06:10:00 -0400 Received: from mga04.intel.com ([192.55.52.120]:7834 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933887AbdGTKJ5 (ORCPT ); Thu, 20 Jul 2017 06:09:57 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,383,1496127600"; d="scan'208";a="1153413824" Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix an error handling path in 'mock_gem_device()' To: Christophe JAILLET , daniel.vetter@intel.com, jani.nikula@linux.intel.com, airlied@linux.ie, chris@chris-wilson.co.uk, tvrtko.ursulin@intel.com Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20170719223503.30580-1-christophe.jaillet@wanadoo.fr> From: Tvrtko Ursulin Message-ID: <60bf1e8d-f74c-b1b8-96fa-67a1b82c0112@linux.intel.com> Date: Thu, 20 Jul 2017 11:09:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170719223503.30580-1-christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 31 On 19/07/2017 23:35, Christophe JAILLET wrote: > Goto the right label in case of error, otherwise there is a leak. > This has been introduced by c5cf9a9147ff. In this patch a goto has not been > updated. > > Fixes: c5cf9a9147ff ("drm/i915: Create a kmem_cache to allocate struct i915_priolist from") > Signed-off-by: Christophe JAILLET > --- > drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > index 627e2aa09766..8cdec455cf7d 100644 > --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > @@ -206,7 +206,7 @@ struct drm_i915_private *mock_gem_device(void) > mkwrite_device_info(i915)->ring_mask = BIT(0); > i915->engine[RCS] = mock_engine(i915, "mock"); > if (!i915->engine[RCS]) > - goto err_dependencies; > + goto err_priorities; > > i915->kernel_context = mock_context(i915, NULL); > if (!i915->kernel_context) Reviewed-by: Tvrtko Ursulin Regards, Tvrtko