Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965274AbdGTKbT (ORCPT ); Thu, 20 Jul 2017 06:31:19 -0400 Received: from mail.skyhub.de ([5.9.137.197]:39928 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965256AbdGTKbP (ORCPT ); Thu, 20 Jul 2017 06:31:15 -0400 Date: Thu, 20 Jul 2017 12:31:05 +0200 From: Borislav Petkov To: Arvind Yadav Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, tony.luck@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures. Message-ID: <20170720103105.GD18424@nazgul.tnic> References: <1500535305-9369-1-git-send-email-arvind.yadav.cs@gmail.com> <1500535305-9369-8-git-send-email-arvind.yadav.cs@gmail.com> <20170720081207.GA18424@nazgul.tnic> <27e82108-10c3-a411-d6ad-c399b603db82@gmail.com> <20170720082850.GB18424@nazgul.tnic> <3e870042-56ec-8b12-98e7-2110c7b75ac5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3e870042-56ec-8b12-98e7-2110c7b75ac5@gmail.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 559 Lines: 17 On Thu, Jul 20, 2017 at 02:31:09PM +0530, Arvind Yadav wrote: > > "Constify attribute_group structs because they don't change at runtime." > I can add this as subject. But we should avoid lengthy subject. Are you actually reading what I'm writing to you? I said this should be the commit message, not the subject. What I'm saying is, shorten your commit message - no need for the irrelevant before/after sizes. I'm not the first reviewer to ask WTF do those things even mean. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --