Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935870AbdGTKxE convert rfc822-to-8bit (ORCPT ); Thu, 20 Jul 2017 06:53:04 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:57159 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934348AbdGTKxC (ORCPT ); Thu, 20 Jul 2017 06:53:02 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Tvrtko Ursulin , "Christophe JAILLET" , daniel.vetter@intel.com, jani.nikula@linux.intel.com, airlied@linux.ie, tvrtko.ursulin@intel.com From: Chris Wilson In-Reply-To: <60bf1e8d-f74c-b1b8-96fa-67a1b82c0112@linux.intel.com> Cc: intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20170719223503.30580-1-christophe.jaillet@wanadoo.fr> <60bf1e8d-f74c-b1b8-96fa-67a1b82c0112@linux.intel.com> Message-ID: <150054796988.7317.13232227022876303266@mail.alporthouse.com> User-Agent: alot/0.3.6 Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix an error handling path in 'mock_gem_device()' Date: Thu, 20 Jul 2017 11:52:49 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1346 Lines: 31 Quoting Tvrtko Ursulin (2017-07-20 11:09:53) > > On 19/07/2017 23:35, Christophe JAILLET wrote: > > Goto the right label in case of error, otherwise there is a leak. > > This has been introduced by c5cf9a9147ff. In this patch a goto has not been > > updated. > > > > Fixes: c5cf9a9147ff ("drm/i915: Create a kmem_cache to allocate struct i915_priolist from") > > Signed-off-by: Christophe JAILLET > > --- > > drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > index 627e2aa09766..8cdec455cf7d 100644 > > --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > +++ b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > > @@ -206,7 +206,7 @@ struct drm_i915_private *mock_gem_device(void) > > mkwrite_device_info(i915)->ring_mask = BIT(0); > > i915->engine[RCS] = mock_engine(i915, "mock"); > > if (!i915->engine[RCS]) > > - goto err_dependencies; > > + goto err_priorities; > > > > i915->kernel_context = mock_context(i915, NULL); > > if (!i915->kernel_context) > > Reviewed-by: Tvrtko Ursulin Thanks for the fix and review, pushed. -Chris