Subject: Re: [PATCH 7/7] x86: microcode: constify attribute_group structures.
To: Borislav Petkov <bp@alien8.de>
References: <1500535305-9369-1-git-send-email-arvind.yadav.cs@gmail.com>
 <1500535305-9369-8-git-send-email-arvind.yadav.cs@gmail.com>
 <20170720081207.GA18424@nazgul.tnic>
 <27e82108-10c3-a411-d6ad-c399b603db82@gmail.com>
 <20170720082850.GB18424@nazgul.tnic>
 <3e870042-56ec-8b12-98e7-2110c7b75ac5@gmail.com>
 <20170720103105.GD18424@nazgul.tnic>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        tony.luck@intel.com, linux-kernel@vger.kernel.org
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Message-ID: <3725e8de-7b65-165a-41cc-499771a4eaae@gmail.com>
Date: Thu, 20 Jul 2017 16:31:38 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20170720103105.GD18424@nazgul.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 671
Lines: 18

Hi,


On Thursday 20 July 2017 04:01 PM, Borislav Petkov wrote:
> On Thu, Jul 20, 2017 at 02:31:09PM +0530, Arvind Yadav wrote:
>>> "Constify attribute_group structs because they don't change at runtime."
>> I can add this as subject. But we should avoid lengthy subject.
> Are you actually reading what I'm writing to you? I said this should be
> the commit message, not the subject.
>
> What I'm saying is, shorten your commit message - no need for the
> irrelevant before/after sizes. I'm not the first reviewer to ask WTF do
> those things even mean.
>
Thanks :) for your suggestion. I will remove before/after size comparison.
and send you back for review.

~arvind