Message-ID: <a9bf9482a8e739415d0253cb37d3d53a-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAhaW34HVVc=-webmailer1@server01.webmailer.webmailer.hosteurope.de>
In-Reply-To: <20170718130400.25436-1-colin.king@canonical.com>
References: <20170718130400.25436-1-colin.king@canonical.com>
Date: Thu, 20 Jul 2017 13:03:22 +0200
Subject: Re: [PATCH 1/3][staging-next] staging: pi433: Make a couple of
 functions static
From: "Wolf Entwicklungen" <Marcus.Wolf@Wolf-Entwicklungen.de>
To: "Colin King" <colin.king@canonical.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Marcus Wolf" <linux@Wolf-Entwicklungen.de>,
        devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Reply-To: Marcus.Wolf@Wolf-Entwicklungen.de
User-Agent: Host Europe Webmailer/1.0
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Importance: Normal
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1258
Lines: 44

Reviewed-by: Marcus Wolf <linux@wolf-entwicklungen.de>

Am Di, 18.07.2017, 15:03 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The functions pi433_receive and pi433_tx_thread are local to the source
> and do not need to be in global scope, so make them static
>
> Cleans up sparse warnings:
> symbol 'pi433_receive' was not declared. Should it be static?
> symbol 'pi433_tx_thread' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/staging/pi433/pi433_if.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index d9328ce5ec1d..95930a192de4 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -313,7 +313,7 @@ pi433_start_rx(struct pi433_device *dev)
>
>  /*-------------------------------------------------------------------------*/
>
> -int
> +static int
>  pi433_receive(void *data)
>  {
>  	struct pi433_device *dev = data;
> @@ -463,7 +463,7 @@ pi433_receive(void *data)
>  		return bytes_total;
>  }
>
> -int
> +static int
>  pi433_tx_thread(void *data)
>  {
>  	struct pi433_device *device = data;
> --
> 2.11.0
>
>
>