Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936074AbdGTLEM (ORCPT ); Thu, 20 Jul 2017 07:04:12 -0400 Received: from mailout02.webmailer.hosteurope.de ([80.237.138.58]:36095 "EHLO mailout02.webmailer.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934565AbdGTLEK (ORCPT ); Thu, 20 Jul 2017 07:04:10 -0400 X-Squirrel-UserHash: EhVcX1pHQwdXWkQFBhENSgEKLlwACw== X-Squirrel-FromHash: UwFaC1lCF1E= Message-ID: In-Reply-To: <20170718130400.25436-2-colin.king@canonical.com> References: <20170718130400.25436-1-colin.king@canonical.com> <20170718130400.25436-2-colin.king@canonical.com> Date: Thu, 20 Jul 2017 13:04:09 +0200 Subject: Re: [PATCH 2/3][staging-next] staging: pi433: Make functions rf69_set_bandwidth_intern static From: "Wolf Entwicklungen" To: "Colin King" Cc: "Greg Kroah-Hartman" , "Marcus Wolf" , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: Marcus.Wolf@Wolf-Entwicklungen.de User-Agent: Host Europe Webmailer/1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, license restriction X-KLMS-AntiPhishing: not scanned, license restriction X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2017/07/20 02:14:00 #10132889; khse: 2015-01-01 01:01:01 X-KLMS-AntiVirus-Status: Clean, skipped X-HE-Access: Yes X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1500548649;a6407f71; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1211 Lines: 36 Reviewed-by: Marcus Wolf Am Di, 18.07.2017, 15:03 schrieb Colin King: > From: Colin Ian King > > The function rf69_set_bandwidth_intern is local to the source > and do not need to be in global scope, so make it static. Also > break overly wide line. > > Cleans up sparse warning: > symbol 'update_share_count' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > drivers/staging/pi433/rf69.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index e391ce777bc7..04af906476e3 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -433,7 +433,8 @@ int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum dccPer > return rf69_set_dc_cut_off_frequency_intern(spi, REG_AFCBW, dccPercent); > } > > -int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent) > +static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, > + enum mantisse mantisse, u8 exponent) > { > u8 newValue; > > -- > 2.11.0 > > >