Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934758AbdGTLEq (ORCPT ); Thu, 20 Jul 2017 07:04:46 -0400 Received: from mailout02.webmailer.hosteurope.de ([80.237.138.58]:36105 "EHLO mailout02.webmailer.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936151AbdGTLEp (ORCPT ); Thu, 20 Jul 2017 07:04:45 -0400 X-Squirrel-UserHash: EhVcX1pHQwdXWkQFBhENSgEKLlwACw== X-Squirrel-FromHash: UwFaC1lCF1E= Message-ID: <97b79836d4ba67961ba1d69bd3a5b952-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAhaW34HXVY=-webmailer1@server01.webmailer.webmailer.hosteurope.de> In-Reply-To: <20170716144858.643-2-rjosephwright@gmail.com> References: <20170716144858.643-1-rjosephwright@gmail.com> <20170716144858.643-2-rjosephwright@gmail.com> Date: Thu, 20 Jul 2017 13:04:43 +0200 Subject: Re: [PATCH 1/2] Staging: pi433: declare functions static From: "Wolf Entwicklungen" To: "Joseph Wright" Cc: gregkh@linuxfoundation.org, linux@Wolf-Entwicklungen.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, "Joseph Wright" Reply-To: Marcus.Wolf@Wolf-Entwicklungen.de User-Agent: Host Europe Webmailer/1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, license restriction X-KLMS-AntiPhishing: not scanned, license restriction X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2017/07/20 02:14:00 #10132889; khse: 2015-01-01 01:01:01 X-KLMS-AntiVirus-Status: Clean, skipped X-HE-Access: Yes X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1500548683;2b0732fc; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 40 Reviewed-by: Marcus Wolf Am So, 16.07.2017, 16:48 schrieb Joseph Wright: > Declare functions static to fix sparse warnings: > > warning: symbol 'pi433_receive' was not declared. Should it be static? > warning: symbol 'pi433_tx_thread' was not declared. Should it be static? > > Signed-off-by: Joseph Wright > --- > drivers/staging/pi433/pi433_if.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c > index 1bc478a..46461b4 100644 > --- a/drivers/staging/pi433/pi433_if.c > +++ b/drivers/staging/pi433/pi433_if.c > @@ -313,7 +313,7 @@ pi433_start_rx(struct pi433_device *dev) > > /*-------------------------------------------------------------------------*/ > > -int > +static int > pi433_receive(void *data) > { > struct pi433_device *dev = data; > @@ -463,7 +463,7 @@ pi433_receive(void *data) > return bytes_total; > } > > -int > +static int > pi433_tx_thread(void *data) > { > struct pi433_device *device = data; > -- > 2.9.3 > > >