Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965208AbdGTLGO (ORCPT ); Thu, 20 Jul 2017 07:06:14 -0400 Received: from mailout02.webmailer.hosteurope.de ([80.237.138.58]:36128 "EHLO mailout02.webmailer.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934717AbdGTLGL (ORCPT ); Thu, 20 Jul 2017 07:06:11 -0400 X-Squirrel-UserHash: EhVcX1pHQwdXWkQFBhENSgEKLlwACw== X-Squirrel-FromHash: UwFaC1lCF1E= Message-ID: <09f3fb6cf60869cc59d8c066ffe57037-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAhaW34GU1I=-webmailer1@server01.webmailer.webmailer.hosteurope.de> In-Reply-To: <3d0aa578-eda9-1604-02ff-cf21e7a06a5b@infradead.org> References: <3d0aa578-eda9-1604-02ff-cf21e7a06a5b@infradead.org> Date: Thu, 20 Jul 2017 13:06:07 +0200 Subject: Re: [PATCH -next] staging: pi433: depends on SPI From: "Wolf Entwicklungen" To: "Randy Dunlap" Cc: "LKML" , devel@linuxdriverproject.org, "Greg Kroah-Hartman" , "Marcus Wolf" Reply-To: Marcus.Wolf@Wolf-Entwicklungen.de User-Agent: Host Europe Webmailer/1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, license restriction X-KLMS-AntiPhishing: not scanned, license restriction X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2017/07/20 02:14:00 #10132889; khse: 2015-01-01 01:01:01 X-KLMS-AntiVirus-Status: Clean, skipped X-HE-Access: Yes X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1500548769;3f343fc1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1757 Lines: 45 Reviewed-by: Marcus Wolf Am Do, 20.07.2017, 01:58 schrieb Randy Dunlap: > From: Randy Dunlap > > The pi433 driver uses SPI interfaces so it should depend on SPI. > Also, the "default n" can be removed since that is already the > default. > > Fixes these build errors when SPI is not enabled: > > drivers/staging/pi433/pi433_if.o: In function `pi433_probe': > pi433_if.c:(.text+0x1135): undefined reference to `spi_setup' > pi433_if.c:(.text+0x1177): undefined reference to `spi_write_then_read' > drivers/staging/pi433/pi433_if.o: In function `pi433_init': > pi433_if.c:(.init.text+0xb8): undefined reference to `__spi_register_driver' > drivers/staging/pi433/rf69.o: In function `rf69_read_fifo': > rf69.c:(.text+0x102): undefined reference to `spi_sync' > drivers/staging/pi433/rf69.o: In function `rf69_write_fifo': > rf69.c:(.text+0x248): undefined reference to `spi_sync' > drivers/staging/pi433/rf69.o: In function `rf69_read_reg': > rf69.c:(.text+0x290): undefined reference to `spi_write_then_read' > drivers/staging/pi433/rf69.o: In function `rf69_write_reg': > rf69.c:(.text+0x523): undefined reference to `spi_sync' > > Signed-off-by: Randy Dunlap > Cc: Marcus Wolf > --- > drivers/staging/pi433/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- next-2017-0719.orig/drivers/staging/pi433/Kconfig > +++ next-2017-0719/drivers/staging/pi433/Kconfig > @@ -1,6 +1,6 @@ > config PI433 > tristate "Pi433 - a 433MHz radio module for Raspberry Pi" > - default n > + depends on SPI > ---help--- > This option allows you to enable support for the radio module Pi433. > > > > >