Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935093AbdGTM6v (ORCPT ); Thu, 20 Jul 2017 08:58:51 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:56102 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934307AbdGTM6u (ORCPT ); Thu, 20 Jul 2017 08:58:50 -0400 Subject: Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static To: Marcus.Wolf@Wolf-Entwicklungen.de, Greg Kroah-Hartman References: <20170718130400.25436-1-colin.king@canonical.com> <20170718130400.25436-2-colin.king@canonical.com> <294e80854a10c63451cf3e9d7ca02bce-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAhaW34EVVM=-webmailer1@server01.webmailer.webmailer.hosteurope.de> Cc: Marcus Wolf , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: <150dbc9b-5e7a-97b2-94a9-f7067b06e4a7@canonical.com> Date: Thu, 20 Jul 2017 13:58:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <294e80854a10c63451cf3e9d7ca02bce-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAhaW34EVVM=-webmailer1@server01.webmailer.webmailer.hosteurope.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 35 On 20/07/17 12:01, Wolf Entwicklungen wrote: > Declare rf69_set_dc_cut_off_frequency_intern as static since it > is used internaly only > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Marcus Wolf > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -433,7 +433,7 @@ > return rf69_set_dc_cut_off_frequency_intern(spi, REG_AFCBW, dccPercent); > } > > -int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent) > +static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent) > { > u8 newValue; > diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h > --- a/drivers/staging/pi433/rf69.h > +++ b/drivers/staging/pi433/rf69.h > @@ -41,7 +41,6 @@ > int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance antennaImpedance); > int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain); > enum lnaGain rf69_get_lna_gain(struct spi_device *spi); > -int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum dccPercent dccPercent); > int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent dccPercent); > int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum dccPercent dccPercent); > int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 exponent); > This is better than my original patch, so ignore my patch "staging: pi433: Make functions rf69_set_bandwidth_intern static" Colin