Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754813AbdGTNWA (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Jul 2017 09:22:00 -0400
Received: from mail.kernel.org ([198.145.29.99]:47022 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754726AbdGTNV7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Jul 2017 09:21:59 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F01D622B4E
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org
Date: Thu, 20 Jul 2017 09:21:56 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Chunyu Hu <chuhu@redhat.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, mhiramat@kernel.org,
        shuwang@redhat.com, liwang@redhat.com
Subject: Re: [PATCH] tracing: Fix kmemleak in instance_rmdir
Message-ID: <20170720092156.6b77b64b@gandalf.local.home>
In-Reply-To: <1500546969-12594-1-git-send-email-chuhu@redhat.com>
References: <1500546969-12594-1-git-send-email-chuhu@redhat.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1514
Lines: 46

On Thu, 20 Jul 2017 18:36:09 +0800
Chunyu Hu <chuhu@redhat.com> wrote:

> Hit the kmemleak when executing instance_rmdir, it forgot releasing
> mem of tracing_cpumask. With this fix, the warn does not appear any
> more.

Thanks, applied!

-- Steve

> 
> unreferenced object 0xffff93a8dfaa7c18 (size 8):
>   comm "mkdir", pid 1436, jiffies 4294763622 (age 9134.308s)
>   hex dump (first 8 bytes):
>     ff ff ff ff ff ff ff ff                          ........
>   backtrace:
>     [<ffffffff88b6567a>] kmemleak_alloc+0x4a/0xa0
>     [<ffffffff8861ea41>] __kmalloc_node+0xf1/0x280
>     [<ffffffff88b505d3>] alloc_cpumask_var_node+0x23/0x30
>     [<ffffffff88b5060e>] alloc_cpumask_var+0xe/0x10
>     [<ffffffff88571ab0>] instance_mkdir+0x90/0x240
>     [<ffffffff886e5100>] tracefs_syscall_mkdir+0x40/0x70
>     [<ffffffff886565c9>] vfs_mkdir+0x109/0x1b0
>     [<ffffffff8865b1d0>] SyS_mkdir+0xd0/0x100
>     [<ffffffff88403857>] do_syscall_64+0x67/0x150
>     [<ffffffff88b710e7>] return_from_SYSCALL_64+0x0/0x6a
>     [<ffffffffffffffff>] 0xffffffffffffffff
> 
> Signed-off-by: Chunyu Hu <chuhu@redhat.com>
> ---
>  kernel/trace/trace.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 2d0ffcc..42b9355 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -7774,6 +7774,7 @@ static int instance_rmdir(const char *name)
>  	}
>  	kfree(tr->topts);
>  
> +	free_cpumask_var(tr->tracing_cpumask);
>  	kfree(tr->name);
>  	kfree(tr);
>