Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935705AbdGTNnj (ORCPT ); Thu, 20 Jul 2017 09:43:39 -0400 Received: from mx2.suse.de ([195.135.220.15]:42313 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934130AbdGTNni (ORCPT ); Thu, 20 Jul 2017 09:43:38 -0400 Date: Thu, 20 Jul 2017 15:43:36 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Christos Gkekas cc: Joe Perches , Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify. In-Reply-To: <1499541948-3392-1-git-send-email-chris.gekas@gmail.com> Message-ID: References: <1499541948-3392-1-git-send-email-chris.gekas@gmail.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 328 Lines: 13 On Sat, 8 Jul 2017, Christos Gkekas wrote: > Variable mode in method wacom_show_remote_mode() is defined as u8, thus > statement (mode >= 0) is always true and should be removed, simplifying > the logic. > > Signed-off-by: Christos Gkekas Applied to for-4.14/wacom, thanks. -- Jiri Kosina SUSE Labs