Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964830AbdGTNqW (ORCPT ); Thu, 20 Jul 2017 09:46:22 -0400 Received: from mx2.suse.de ([195.135.220.15]:42504 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934130AbdGTNqU (ORCPT ); Thu, 20 Jul 2017 09:46:20 -0400 Date: Thu, 20 Jul 2017 15:46:18 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: "Gustavo A. R. Silva" cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina Subject: Re: [PATCH] HID: hid-logitech-hidpp: add NULL check on devm_kmemdup() return value In-Reply-To: <20170707051213.GA6074@embeddedgus> Message-ID: References: <20170707051213.GA6074@embeddedgus> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 27 On Fri, 7 Jul 2017, Gustavo A. R. Silva wrote: > Check return value from call to devm_kmemdup() > in order to prevent a NULL pointer dereference. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/hid/hid-logitech-hidpp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c > index 41b3946..501e16a 100644 > --- a/drivers/hid/hid-logitech-hidpp.c > +++ b/drivers/hid/hid-logitech-hidpp.c > @@ -2732,6 +2732,9 @@ static int hidpp_initialize_battery(struct hidpp_device *hidpp) > hidpp_battery_props, > sizeof(hidpp_battery_props), > GFP_KERNEL); > + if (!battery_props) > + return -ENOMEM; > + Applied to for-4.13/upstream-fixes, thanks. -- Jiri Kosina SUSE Labs