Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936314AbdGTNy7 (ORCPT ); Thu, 20 Jul 2017 09:54:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:43085 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S935292AbdGTNy6 (ORCPT ); Thu, 20 Jul 2017 09:54:58 -0400 Date: Thu, 20 Jul 2017 15:54:46 +0200 From: Borislav Petkov To: Punit Agrawal Cc: linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Message-ID: <20170720135446.GA20641@nazgul.tnic> References: <20170720110402.15313-1-punit.agrawal@arm.com> <20170720110402.15313-4-punit.agrawal@arm.com> <20170720111732.GC18515@nazgul.tnic> <87d18vmgv6.fsf@e105922-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87d18vmgv6.fsf@e105922-lin.cambridge.arm.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 626 Lines: 18 On Thu, Jul 20, 2017 at 01:29:17PM +0100, Punit Agrawal wrote: > I agree that where there is a genuine problem, relevant messages can > help to diagnose the problem. But what's printed now doesn't fit the > criteria. So make it fit the criteria. Change the code to not issue that message when the platform doesn't have those tables. But keep it in the remaining cases, when the tables are there. You can't be removing useful error messages just because your platform doesn't have the tables. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --