Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932990AbdGTO2g (ORCPT ); Thu, 20 Jul 2017 10:28:36 -0400 Received: from conssluserg-04.nifty.com ([210.131.2.83]:39871 "EHLO conssluserg-04.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbdGTO2d (ORCPT ); Thu, 20 Jul 2017 10:28:33 -0400 X-Greylist: delayed 157771 seconds by postgrey-1.27 at vger.kernel.org; Thu, 20 Jul 2017 10:28:32 EDT DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com v6KESK5s030264 X-Nifty-SrcIP: [209.85.213.169] MIME-Version: 1.0 In-Reply-To: References: <20170630225822.25349-1-sboyd@codeaurora.org> From: Masahiro Yamada Date: Thu, 20 Jul 2017 23:28:18 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kbuild: modpost: Warn about references from rodata to __init text To: Rob Clark , Stephen Boyd Cc: Michal Marek , Linux Kernel Mailing List , linux-arm-msm , "linux-arm-kernel@lists.infradead.org" , Linux Kbuild mailing list , Bjorn Andersson Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1692 Lines: 38 Hi Stephen, Rob, 2017-07-01 8:59 GMT+09:00 Rob Clark : > On Fri, Jun 30, 2017 at 6:58 PM, Stephen Boyd wrote: >> If we have a structure that's marked const it will be placed >> into the .rodata section but it could reference an init section >> function. Include the read only data section in the check we have >> for read/write data sections referencing init sections so we can >> find this class of problems. This exposes quite a few places >> where const marked structures are referencing __init functions and >> __init data that we were previously ignoring. >> >> Cc: Rob Clark >> Cc: Bjorn Andersson >> Signed-off-by: Stephen Boyd >> --- >> >> Making this change leads to quite a few other errors even on the >> multi_v7_defconfig for ARM[1]. I still need to do a build of the >> allmodconfig to see how many other errors there, but it seems to >> be quite a few. I suppose those will need to be fixed before we can >> merge this? > > thanks.. the explosions you get with these mistakes when building > drivers as modules in a distro kernel config are quite "fun" to > debug.. > > I'm not quite sure about the rules for whether merging this would > count as a regression, but I would argue those drivers are already > broken, just no one noticed yet. Similar to when a new gcc gets more > clever about detecting bugs. So I wouldn't be against merging this > first to force drivers to fix their crap ;-) I applied this, but this way seems unacceptable. I cannot send a pull-req for this unless most of the warnings are fixed. Is there any activity for driver fixes?