Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964861AbdGTPD5 (ORCPT ); Thu, 20 Jul 2017 11:03:57 -0400 Received: from wp244.webpack.hosteurope.de ([80.237.133.13]:33038 "EHLO wp244.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935186AbdGTPD4 (ORCPT ); Thu, 20 Jul 2017 11:03:56 -0400 Date: Thu, 20 Jul 2017 17:03:53 +0200 (CEST) From: Marcus Wolf To: Colin Ian King , Greg Kroah-Hartman Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Message-ID: <1086733937.6514.1500563033567@ox.hosteurope.de> In-Reply-To: <150dbc9b-5e7a-97b2-94a9-f7067b06e4a7@canonical.com> References: <20170718130400.25436-1-colin.king@canonical.com> <20170718130400.25436-2-colin.king@canonical.com> <294e80854a10c63451cf3e9d7ca02bce-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAhaW34EVVM=-webmailer1@server01.webmailer.webmailer.hosteurope.de> <150dbc9b-5e7a-97b2-94a9-f7067b06e4a7@canonical.com> Subject: Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.3-Rev27 X-Originating-Client: com.openexchange.ox.gui.dhtml X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1500563036;641ba8fb; X-HE-SMSGID: 1dYCzZ-0003Rm-Ld Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2005 Lines: 56 Hi Colin, mine is an aditional patch for an other function, that's pretty similar to the one, you improoved. So we need both patches, yours and mine! Cheers, Marcus > Colin Ian King hat am 20. Juli 2017 um 14:58 > geschrieben: > > > On 20/07/17 12:01, Wolf Entwicklungen wrote: > > Declare rf69_set_dc_cut_off_frequency_intern as static since it > > is used internaly only > > > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > > Signed-off-by: Marcus Wolf > > > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > > --- a/drivers/staging/pi433/rf69.c > > +++ b/drivers/staging/pi433/rf69.c > > @@ -433,7 +433,7 @@ > > return rf69_set_dc_cut_off_frequency_intern(spi, REG_AFCBW, dccPercent); > > } > > > > -int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse > > mantisse, u8 exponent) > > +static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum > > mantisse mantisse, u8 exponent) > > { > > u8 newValue; > > diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h > > --- a/drivers/staging/pi433/rf69.h > > +++ b/drivers/staging/pi433/rf69.h > > @@ -41,7 +41,6 @@ > > int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance > > antennaImpedance); > > int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain); > > enum lnaGain rf69_get_lna_gain(struct spi_device *spi); > > -int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, > > enum dccPercent dccPercent); > > int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent > > dccPercent); > > int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum > > dccPercent dccPercent); > > int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 > > exponent); > > > > This is better than my original patch, so ignore my patch "staging: > pi433: Make functions rf69_set_bandwidth_intern static" > > Colin >