Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965492AbdGTPjy (ORCPT ); Thu, 20 Jul 2017 11:39:54 -0400 Received: from ale.deltatee.com ([207.54.116.67]:45929 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965298AbdGTPjw (ORCPT ); Thu, 20 Jul 2017 11:39:52 -0400 To: =?UTF-8?Q?Horia_Geant=c4=83?= , Michael Ellerman , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-ntb@googlegroups.com" , "linux-crypto@vger.kernel.org" References: <20170718165528.7383-1-logang@deltatee.com> <20170718165528.7383-2-logang@deltatee.com> <87iniphsug.fsf@concordia.ellerman.id.au> <15b6ea7d-5817-c0cd-aee4-c8a52d8808f9@deltatee.com> Cc: Arnd Bergmann , Greg Kroah-Hartman , Stephen Bates , Benjamin Herrenschmidt , Paul Mackerras , Nicholas Piggin , Suresh Warrier , "Oliver O'Halloran" From: Logan Gunthorpe Message-ID: Date: Thu, 20 Jul 2017 09:39:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: oohall@gmail.com, warrier@linux.vnet.ibm.com, npiggin@gmail.com, paulus@samba.org, benh@kernel.crashing.org, sbates@raithlin.com, gregkh@linuxfoundation.org, arnd@arndb.de, linux-crypto@vger.kernel.org, linux-ntb@googlegroups.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, mpe@ellerman.id.au, horia.geanta@nxp.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v4 1/5] powerpc: io.h: move iomap.h include so that it can use readq/writeq defs X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 603 Lines: 20 On 20/07/17 06:36 AM, Horia Geant? wrote: > include/asm-generic/iomap.h is included before > include/linux/io-64-nonatomic-lo-hi.h: > > include/linux/io.h -> arch/powerpc/include/asm/io.h -> > include/asm-generic/iomap.h > > Thus, the "extern" version of ioread64_lo_hi and friends will be used > (and not the inline version from io-64-nonatomic-lo-hi.h). > > But for this kernel .config: > -CONFIG_GENERIC_IOMAP=n and > -there is no implementation of io{read|write}64[be]{_lo_hi|_hi_lo} in > arch/powerpc/kernel/iomap.c Ah, thanks for the triage. I'll take a look at fixing this for a v5. Logan