Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936556AbdGTP5g (ORCPT ); Thu, 20 Jul 2017 11:57:36 -0400 Received: from wp244.webpack.hosteurope.de ([80.237.133.13]:32894 "EHLO wp244.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934668AbdGTP5f (ORCPT ); Thu, 20 Jul 2017 11:57:35 -0400 Date: Thu, 20 Jul 2017 17:57:30 +0200 (CEST) From: Marcus Wolf To: Dan Carpenter , Geert Uytterhoeven , "kbuild-all@01.org" , Greg KH , "linux-kernel@vger.kernel.org" , driverdevel , "devicetree@vger.kernel.org" , Grant Likely , Rob Herring Message-ID: <40815037.7071.1500566250933@ox.hosteurope.de> In-Reply-To: References: <39f4e59cae6d241235f8f2cc6eebb33c-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAheVn4GUFc=-webmailer1@server05.webmailer.hosteurope.de> <201707172156.DCyTyWc2%fengguang.wu@intel.com> <652336354.3806.1500549785404@ox.hosteurope.de> <20170720113705.d65hxm3jbki2ynqd@mwanda> Subject: Test of [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.3-Rev27 X-Originating-Client: com.openexchange.ox.gui.dhtml X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1500566255;493d15ea; X-HE-SMSGID: 1dYDpT-0003n5-1M Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2043 Lines: 70 Hi! Since I don't have an environment for m68k and I would appreciate not having to set it up, I would be very happy, if someone could give the patch, named in the subjext, a try on ARCH=m68k... Thanks, Marcus > Geert Uytterhoeven hat am 20. Juli 2017 um 14:27 > geschrieben: > > > Hi Dan, > > On Thu, Jul 20, 2017 at 1:37 PM, Dan Carpenter > wrote: > > On Thu, Jul 20, 2017 at 01:23:05PM +0200, Marcus Wolf wrote: > >> below you can see the report with the error on m68k. It was sent to me from > >> a > >> test robot of intel. > >> > >> According to my research, this problem occured, because there is no > >> hardware > >> support for floating point on the m68k (or it was configured not to use > >> it). > >> Therefore gcc uses an internal function, provided by libgcc. Obviously > >> libgcc > >> wasn't linked... > >> > >> I don't know how to come arround this problem by modifying my code (except > >> reducing the accuracy of the calculation by not using floating point). > > > > I don't see any floating point? You're not allowed to use floating > > point in the kernel. > > Indeed. __udivdi3 is used for 64-bit by 32-bit division. > > >> Can we ignore the error or can I do something else? > >> Maybe a special include just in case of m68k can help??!? > >> I don't have an environment for building m68k. > > https://www.kernel.org/pub/tools/crosstool/ > > > I think the answer is to use div_u64() and div64_u64 instead of > > do_div()? > > do_div() is fine > The link error is not caused by do_div(), but by not using do_div() where > needed. > > > Or you could just add a depend in the Kconfig. > > Depend on what? !M68K? It's gonna fail on several 32-bit platforms. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds >