Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S936640AbdGTRjC (ORCPT <rfc822;w@1wt.eu>);
        Thu, 20 Jul 2017 13:39:02 -0400
Received: from relay06.alfahosting-server.de ([109.237.142.242]:59846 "EHLO
        relay06.alfahosting-server.de" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S934775AbdGTRjA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 20 Jul 2017 13:39:00 -0400
X-Spam-DCC: : 
Subject: Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support
To: Fabio Estevam <festevam@gmail.com>, Richard Leitner <dev@g0hl1n.net>
References: <1497337054-4911-1-git-send-email-richard.leitner@skidata.com>
 <CAOMZO5Cx6OrYSKYcbj6DWhn=hzS51sENadWHLSYdTkjRk9qJXw@mail.gmail.com>
 <3b154ab9-6bbd-eb53-05e6-6d08cf3cc5c0@g0hl1n.net>
 <CAOMZO5Cp7keQSEcR+wV_Z6PTxYgr_xYxdcG_TDd+UUJne0R7xg@mail.gmail.com>
Cc: Richard Leitner <richard.leitner@skidata.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Clemens Gruber <clemens.gruber@pqgruber.com>, kalle.kankare@vincit.fi,
        Eric Nelson <eric@nelint.com>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Fabio Estevam <fabio.estevam@nxp.com>
From: Richard Leitner <dev@g0hl1n.net>
Message-ID: <f499e55f-498b-9954-b3dc-52f704cecd7a@g0hl1n.net>
Date: Thu, 20 Jul 2017 19:38:56 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAOMZO5Cp7keQSEcR+wV_Z6PTxYgr_xYxdcG_TDd+UUJne0R7xg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1260
Lines: 35


On 07/20/2017 07:27 PM, Fabio Estevam wrote:
> Hi Richard,
>
> On Thu, Jul 20, 2017 at 2:25 PM, Richard Leitner <dev@g0hl1n.net> wrote:
>
>> Does this occur only on reboot or everytime the driver tries to read the AVC
>> threshold (avc_get_threshold)?
>> Are you able to set the AVC threshold (using amixer)?
>
> I am not even using the codec. I just run 'reboot' and the problem happens.
>
> The following change fixes the 'reboot' issue for me. Could you please try it?
>
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -409,7 +409,7 @@ static int dac_put_volsw(struct snd_kcontrol *kcontrol,
>  static int avc_get_threshold(struct snd_kcontrol *kcontrol,
>                              struct snd_ctl_elem_value *ucontrol)
>  {
> -       struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
> +       struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);

Thank you for spotting this! That works of course.

I'm sorry, it seems I messed something up during copy/paste for my own 
backport version of this patch. Seems like I tested and sent a different 
version of the patch... That definitely shouldn't have happened :-(

Do you want to send that patch or should I?

Thank you again Fabio!

regards,
Richard.L