Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966098AbdGTRlQ (ORCPT ); Thu, 20 Jul 2017 13:41:16 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:38357 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966030AbdGTRlM (ORCPT ); Thu, 20 Jul 2017 13:41:12 -0400 From: Arvind Yadav To: b.zolnierkie@samsung.com, paulus@samba.org, benh@kernel.crashing.org, adaplas@gmail.com, mbroemme@libmpq.org, FlorianSchandinat@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 21/28] video: fbdev: imsttfb: constify pci_device_id. Date: Thu, 20 Jul 2017 23:09:46 +0530 Message-Id: <1500572393-18844-22-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1149 Lines: 32 pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 6736 856 0 7592 1da8 drivers/video/fbdev/imsttfb.o File size After adding 'const': text data bss dec hex filename 6832 760 0 7592 1da8 drivers/video/fbdev/imsttfb.o Signed-off-by: Arvind Yadav --- drivers/video/fbdev/imsttfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/imsttfb.c b/drivers/video/fbdev/imsttfb.c index 4363c64..ecdcf35 100644 --- a/drivers/video/fbdev/imsttfb.c +++ b/drivers/video/fbdev/imsttfb.c @@ -1318,7 +1318,7 @@ imsttfb_ioctl(struct fb_info *info, u_int cmd, u_long arg) } } -static struct pci_device_id imsttfb_pci_tbl[] = { +static const struct pci_device_id imsttfb_pci_tbl[] = { { PCI_VENDOR_ID_IMS, PCI_DEVICE_ID_IMS_TT128, PCI_ANY_ID, PCI_ANY_ID, 0, 0, IBM }, { PCI_VENDOR_ID_IMS, PCI_DEVICE_ID_IMS_TT3D, -- 2.7.4