Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966114AbdGTRlV (ORCPT ); Thu, 20 Jul 2017 13:41:21 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34913 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966030AbdGTRlS (ORCPT ); Thu, 20 Jul 2017 13:41:18 -0400 From: Arvind Yadav To: b.zolnierkie@samsung.com, paulus@samba.org, benh@kernel.crashing.org, adaplas@gmail.com, mbroemme@libmpq.org, FlorianSchandinat@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 23/28] video: fbdev: gxfb: constify pci_device_id. Date: Thu, 20 Jul 2017 23:09:48 +0530 Message-Id: <1500572393-18844-24-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 32 pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 2643 1616 16 4275 10b3 video/fbdev/geode/gxfb_core.o File size After adding 'const': text data bss dec hex filename 2707 1552 16 4275 10b3 video/fbdev/geode/gxfb_core.o Signed-off-by: Arvind Yadav --- drivers/video/fbdev/geode/gxfb_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/geode/gxfb_core.c b/drivers/video/fbdev/geode/gxfb_core.c index ec9fc9a..f4f7637 100644 --- a/drivers/video/fbdev/geode/gxfb_core.c +++ b/drivers/video/fbdev/geode/gxfb_core.c @@ -474,7 +474,7 @@ static void gxfb_remove(struct pci_dev *pdev) framebuffer_release(info); } -static struct pci_device_id gxfb_id_table[] = { +static const struct pci_device_id gxfb_id_table[] = { { PCI_DEVICE(PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_GX_VIDEO) }, { 0, } }; -- 2.7.4