Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936692AbdGTRpN (ORCPT ); Thu, 20 Jul 2017 13:45:13 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36804 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966004AbdGTRkv (ORCPT ); Thu, 20 Jul 2017 13:40:51 -0400 From: Arvind Yadav To: b.zolnierkie@samsung.com, paulus@samba.org, benh@kernel.crashing.org, adaplas@gmail.com, mbroemme@libmpq.org, FlorianSchandinat@gmx.de Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 14/28] video: fbdev: arkfb: constify pci_device_id. Date: Thu, 20 Jul 2017 23:09:39 +0530 Message-Id: <1500572393-18844-15-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> References: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1087 Lines: 32 pci_device_id are not supposed to change at runtime. All functions working with pci_device_id provided by work with const pci_device_id. So mark the non-const structs as const. File size before: text data bss dec hex filename 12511 1920 0 14431 385f drivers/video/fbdev/arkfb.o File size After adding 'const': text data bss dec hex filename 12607 1824 0 14431 385f drivers/video/fbdev/arkfb.o Signed-off-by: Arvind Yadav --- drivers/video/fbdev/arkfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c index 6a317de..13ba371 100644 --- a/drivers/video/fbdev/arkfb.c +++ b/drivers/video/fbdev/arkfb.c @@ -1157,7 +1157,7 @@ static int ark_pci_resume (struct pci_dev* dev) /* List of boards that we are trying to support */ -static struct pci_device_id ark_devices[] = { +static const struct pci_device_id ark_devices[] = { {PCI_DEVICE(0xEDD8, 0xA099)}, {0, 0, 0, 0, 0, 0, 0} }; -- 2.7.4