Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966018AbdGTWeY (ORCPT ); Thu, 20 Jul 2017 18:34:24 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38422 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965438AbdGTWeW (ORCPT ); Thu, 20 Jul 2017 18:34:22 -0400 Subject: Re: [PATCH] Make functions rf69_set_bandwidth_intern and rf69_set_dc_cut_off_frequency_intern static To: Greg Kroah-Hartman , Marcus Wolf , devel@driverdev.osuosl.org References: <20170720223324.8093-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: <202cd503-a999-0991-3628-001b072c1097@canonical.com> Date: Thu, 20 Jul 2017 23:34:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170720223324.8093-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2754 Lines: 58 Oops, should have been marked as [V2] in the subject line On 20/07/17 23:33, Colin King wrote: > From: Colin Ian King > > The functions rf69_set_bandwidth_intern and also > rf69_set_dc_cut_off_frequency_intern is local to the source and > do not need to be in global scope, so make it static. Also break > break overly wide line. Finally, remove the function declaration > rf69_set_dc_cut_off_frequency_intern from the rf69.h header. > > Cleans up sparse warning: > symbol 'update_share_count' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > drivers/staging/pi433/rf69.c | 7 +++++-- > drivers/staging/pi433/rf69.h | 1 - > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index e391ce777bc7..170e9cc59cde 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -400,7 +400,9 @@ enum lnaGain rf69_get_lna_gain(struct spi_device *spi) > } > } > > -int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi ,u8 reg, enum dccPercent dccPercent) > +static int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, > + u8 reg, > + enum dccPercent dccPercent) > { > switch (dccPercent) { > case dcc16Percent: return WRITE_REG(reg, ( (READ_REG(reg) & ~MASK_BW_DCC_FREQ) | BW_DCC_16_PERCENT) ); > @@ -433,7 +435,8 @@ int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum dccPer > return rf69_set_dc_cut_off_frequency_intern(spi, REG_AFCBW, dccPercent); > } > > -int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mantisse, u8 exponent) > +static int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, > + enum mantisse mantisse, u8 exponent) > { > u8 newValue; > > diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h > index b81e0762032e..3fdf5d3d225b 100644 > --- a/drivers/staging/pi433/rf69.h > +++ b/drivers/staging/pi433/rf69.h > @@ -41,7 +41,6 @@ int rf69_set_pa_ramp(struct spi_device *spi, enum paRamp paRamp); > int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance antennaImpedance); > int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain); > enum lnaGain rf69_get_lna_gain(struct spi_device *spi); > -int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum dccPercent dccPercent); > int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent dccPercent); > int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum dccPercent dccPercent); > int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 exponent); >