Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966071AbdGTWfG (ORCPT ); Thu, 20 Jul 2017 18:35:06 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37292 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965438AbdGTWfF (ORCPT ); Thu, 20 Jul 2017 18:35:05 -0400 Date: Thu, 20 Jul 2017 15:35:04 -0700 (PDT) Message-Id: <20170720.153504.1900186208210668931.davem@davemloft.net> To: tatsu@ab.jp.nec.com Cc: j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: bonding: Fix transmit load balancing in balance-alb mode From: David Miller In-Reply-To: <17EC94B0A072C34B8DCF0D30AD16044A0296FEF5@BPXM09GP.gisp.nec.co.jp> References: <17EC94B0A072C34B8DCF0D30AD16044A0296FEF5@BPXM09GP.gisp.nec.co.jp> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 20 Jul 2017 15:35:04 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 843 Lines: 21 From: Kosuke Tatsukawa Date: Thu, 20 Jul 2017 05:20:40 +0000 > balance-alb mode used to have transmit dynamic load balancing feature > enabled by default. However, transmit dynamic load balancing no longer > works in balance-alb after commit 8b426dc54cf4 ("bonding: remove > hardcoded value"). > > Both balance-tlb and balance-alb use the function bond_do_alb_xmit() to > send packets. This function uses the parameter tlb_dynamic_lb. > tlb_dynamic_lb used to have the default value of 1 for balance-alb, but > now the value is set to 0 except in balance-tlb. > > Re-enable transmit dyanmic load balancing by initializing tlb_dynamic_lb > for balance-alb similar to balance-tlb. > > Signed-off-by: Kosuke Tatsukawa Applied and queued up for -stable, thanks. Andy, thanks for the Fixes: tag.