Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966034AbdGTW5C (ORCPT ); Thu, 20 Jul 2017 18:57:02 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:40608 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965410AbdGTW47 (ORCPT ); Thu, 20 Jul 2017 18:56:59 -0400 From: Mehmet Kayaalp To: ima-devel Cc: containers , linux-kernel , linux-security-module , Tycho Andersen , "Serge E . Hallyn" , Yuqiong Sun , David Safford , Mehmet Kayaalp , Stefan Berger , Guilherme Magalhaes , Mehmet Kayaalp Subject: [RFC PATCH 5/5] ima: Add ns_mnt, dev, ino fields to IMA audit measurement msgs Date: Thu, 20 Jul 2017 18:50:33 -0400 X-Mailer: git-send-email 2.9.4 In-Reply-To: <20170720225033.21298-1-mkayaalp@linux.vnet.ibm.com> References: <20170720225033.21298-1-mkayaalp@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 17072022-0048-0000-0000-000001C77210 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007395; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000214; SDB=6.00890486; UDB=6.00444905; IPR=6.00670653; BA=6.00005482; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016303; XFM=3.00000015; UTC=2017-07-20 22:56:56 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17072022-0049-0000-0000-000041F47CB0 Message-Id: <20170720225033.21298-6-mkayaalp@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-20_12:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707200354 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1862 Lines: 55 From: Guilherme Magalhaes Extending audit measurement record with mount namespace id, file inode, and device name. These fields uniquely identify a pathname considering different mount namespaces. The file inode on a given device is unique and these fields are required to identify a namespace id since this id can be released and later reused by a different process. Signed-off-by: Guilherme Magalhaes Changelog: * Change the field name from "mnt_ns" to "ns_mnt" Signed-off-by: Mehmet Kayaalp --- security/integrity/ima/ima_api.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/security/integrity/ima/ima_api.c b/security/integrity/ima/ima_api.c index 4a77072..084b126 100644 --- a/security/integrity/ima/ima_api.c +++ b/security/integrity/ima/ima_api.c @@ -18,6 +18,7 @@ #include #include #include +#include #include "ima.h" @@ -296,6 +297,7 @@ void ima_audit_measurement(struct integrity_iint_cache *iint, char algo_hash[sizeof(hash) + strlen(algo_name) + 2]; int i; unsigned long flags = iint_flags(iint, status); + struct ns_common *ns; if (flags & IMA_AUDITED) return; @@ -314,6 +316,14 @@ void ima_audit_measurement(struct integrity_iint_cache *iint, audit_log_format(ab, " hash="); snprintf(algo_hash, sizeof(algo_hash), "%s:%s", algo_name, hash); audit_log_untrustedstring(ab, algo_hash); + ns = mntns_operations.get(current); + if (!IS_ERR_OR_NULL(ns)) { + audit_log_format(ab, " ns_mnt=%u", ns->inum); + mntns_operations.put(ns); + } + audit_log_format(ab, " dev="); + audit_log_untrustedstring(ab, iint->inode->i_sb->s_id); + audit_log_format(ab, " ino=%lu", iint->inode->i_ino); audit_log_task_info(ab, current); audit_log_end(ab); -- 2.9.4