Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030201AbdGUB6t (ORCPT ); Thu, 20 Jul 2017 21:58:49 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:44881 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964809AbdGUB6p (ORCPT ); Thu, 20 Jul 2017 21:58:45 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: chenjh@rock-chips.com X-FST-TO: w.egorov@phytec.de X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: chenjh@rock-chips.com X-UNIQUE-TAG: <7007d4a508a341767a7e7f2be662bb38> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v6 08/12] gpio: Add GPIO driver for the RK805 PMIC To: =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: linux-rockchip@lists.infradead.org, Linus Walleij , Tao Huang , Alexandre Courbot , zhangqing@rock-chips.com, "devicetree@vger.kernel.org" , Mark Brown , Dmitry Torokhov , "linux-kernel@vger.kernel.org" , Rob Herring , Liam Girdwood , tony.xie@rock-chips.com, "linux-gpio@vger.kernel.org" , Linux Input , Mark Rutland , w.egorov@phytec.de References: <1496905959-29202-1-git-send-email-chenjh@rock-chips.com> <2451251.ri2bNrhWeM@phil> <1617153.S9fhFArdpW@diego> From: Jianhong Chen Message-ID: <67c2e8bb-dadd-faa3-dcd0-0f325b3cbfce@rock-chips.com> Date: Fri, 21 Jul 2017 10:00:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1617153.S9fhFArdpW@diego> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3040 Lines: 85 在 2017/6/29 18:29, Heiko Stübner 写道: > Hi, > > Am Mittwoch, 14. Juni 2017, 20:11:06 CEST schrieb Jianhong Chen: >> 在 2017/6/9 20:17, Heiko Stuebner 写道: >>> Am Freitag, 9. Juni 2017, 13:37:26 CEST schrieb Linus Walleij: >>>> Heiko, can you please look at this patch. >>>> >>>> On Thu, Jun 8, 2017 at 9:30 AM, Jianhong Chen > wrote: >>>>> From: chenjh >>>> Full name please. >>> git config --global user.name "John Doe" >>> >>> might do the and make this permanent for all your commits :-) >>> >>>>> RK805 has two configurable GPIOs that can be used for several >>>>> purposes. These are output only. >>>>> >>>>> This driver is generic for other Rockchip PMICs to be added. >>>>> >>>>> Signed-off-by: chenjh >>>> Dito. >>>> >>>> Your commit message says they are output-only, yet you implement >>>> .direction_input(). So what is is going to be? >>> So far, I've only seen the rk808 and rk818. Both do not have any >>> configurable pins. >>> >>> The rk805 which is a sort of variant of the above, does have the two >>> pins defined below, but in the manual I could also only find them as >>> output-only and having no other function than being output-pins. >>> >>> So I don't really know if all the input- or "gpio-mode"- handling is only >>> an oversight (copy'n'paste) or if there are yet other rk808 variants >>> around >>> that can actually be configured as inputs or even non-gpio modes? >>> >>> I hope Jianhong will be able to answer that. >>> >>> >>> Heiko >> This driver is not only for rk805, but also intend for rk816 and furtrue >> PMICs. >> The rk816 has one multi function pin(TS/GPIO), when setting as gpio, it >> can be configured as output or input. >> Here is simple description from manual: "Thermistor input. Connect a >> thermistor from this pin to ground. The thermistor is usually inside the >> battery pack. (multi-function for GPIO) ". > As Linus suggested, this sounds like you want a pinctrl driver that > also handles the gpios. > > Ideally you might also directly provide support for this rk816 in the > same patch series, so reviewers can see the full extend of what is > supported. > > > Heiko > Hi, Heiko: I have moved gpio-rk805.c to drivers/pinctrl/pinctrl-rk805.c, this driver is also designed for rk816 or furture PMICs to extend. RK816 is not in our team's plan at this porting, it will be added at next time, so I don't directly provide rk816 in this driver. I will add more descriptions in commit message to express my design purpose. Are you agreed ? If so, I will send [PATCH v7] today. -- Best Regards ---------------------------------------------------------------------------- 陈健洪 (Joseph Chen) E-mail：chenjh@rock-chips.com 福州瑞芯微电子股份有限公司 Fuzhou Rockchip Electronics Co.Ltd 福建省福州市铜盘路软件大道89号软件园A区21号楼 (350003) No. 21 Building, A District, No.89,software Boulevard Fuzhou,Fujian,PRC TEL：0591-83991906/07-8573