Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030245AbdGUDyU (ORCPT ); Thu, 20 Jul 2017 23:54:20 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:32152 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030222AbdGUDyS (ORCPT ); Thu, 20 Jul 2017 23:54:18 -0400 Subject: Re: [PATCH 2/4] gpio: davinci: Handle the return value of davinci_gpio_irq_setup function To: Grygorii Strashko , Johan Hovold References: <1500375436-9435-1-git-send-email-j-keerthy@ti.com> <1500375436-9435-3-git-send-email-j-keerthy@ti.com> <20170719111000.GX29638@localhost> <20170720095047.GA2729@localhost> <47055927-5102-b39f-fdbb-b5d89cb14632@ti.com> <20170720100509.GB2729@localhost> <02965359-ecf1-b934-6b7a-87162d7d00a4@ti.com> CC: , , , , , , , , From: Keerthy Message-ID: Date: Fri, 21 Jul 2017 09:23:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <02965359-ecf1-b934-6b7a-87162d7d00a4@ti.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1661 Lines: 47 On Friday 21 July 2017 03:04 AM, Grygorii Strashko wrote: > > > On 07/20/2017 05:05 AM, Johan Hovold wrote: >> On Thu, Jul 20, 2017 at 03:32:27PM +0530, Keerthy wrote: >>> On Thursday 20 July 2017 03:20 PM, Johan Hovold wrote: >>>> On Thu, Jul 20, 2017 at 02:40:37PM +0530, Keerthy wrote: >>>>> On Thursday 20 July 2017 12:14 PM, Keerthy wrote: >>>>>> On Wednesday 19 July 2017 04:40 PM, Johan Hovold wrote: >> >>>>>>> There's a separate but related bug here too as the clk_prepare_enable() >>>>>>> in davinci_gpio_irq_setup() is never balanced on driver unbind. >>>>>> >>>>>> Yes Johan. I will send that as a separate patch. >>>>> >>>>> This is already fixed in the latest kernel: >>>>> >>>>> commit 6dc0048cff988858254fcc26becfc1e9753efa79 >>>>> Author: Arvind Yadav >>>>> Date: Tue May 23 14:48:57 2017 +0530 >>>> >>>> That change only handles errors in davinci_gpio_irq_setup() (i.e. during >>>> probe) and not the imbalance at driver unbind that I was referring to. >>> >>> Okay got it. One more clk_unprepare_disable() call needs to be there in >>> probe err path. >> >> No, you need to balance it on driver unbind, that is, in a new remove() >> callback. >> > > Sry, but manual driver unbind for this driver is really smth unexpected ;( > So, I'm not sure if it need to be implemented and even yes - it should not be > a part of this patch. Probably, smth like "convert driver to be a module". > The GPIO_DAVINCI config is bool. Thanks for checking on that Grygorii. > By the way, I've tried to unbind gpio-omap, result - failure (expected), > as unbind does not take into account module refcnt state. Okay. > >