Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752400AbdGUHFU (ORCPT ); Fri, 21 Jul 2017 03:05:20 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60468 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751738AbdGUHFT (ORCPT ); Fri, 21 Jul 2017 03:05:19 -0400 From: "Aneesh Kumar K.V" To: Victor Aoqui , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au, khandual@linux.vnet.ibm.com Cc: victora@br.ibm.com, victora@linux.vnet.ibm.com Subject: Re: [PATCH v2] powerpc/mm: Implemented default_hugepagesz verification for powerpc In-Reply-To: <20170720165838.3549-1-victora@linux.vnet.ibm.com> References: <20170720165838.3549-1-victora@linux.vnet.ibm.com> Date: Fri, 21 Jul 2017 12:35:08 +0530 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable x-cbid: 17072107-0040-0000-0000-00000349E218 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17072107-0041-0000-0000-00000CC5D216 Message-Id: <87h8y6p8wr.fsf@skywalker.in.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-21_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707210112 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1503 Lines: 50 Victor Aoqui writes: > Implemented default hugepage size verification (default_hugepagesz=) > in order to allow allocation of defined number of pages (hugepages=) > only for supported hugepage sizes. > > Signed-off-by: Victor Aoqui > --- > v2: > > - Renamed default_hugepage_setup_sz function to hugetlb_default_size_setup; > > - Added powerpc string to error message. > > arch/powerpc/mm/hugetlbpage.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c > index e1bf5ca..3a142fe 100644 > --- a/arch/powerpc/mm/hugetlbpage.c > +++ b/arch/powerpc/mm/hugetlbpage.c > @@ -780,6 +780,21 @@ static int __init hugepage_setup_sz(char *str) > } > __setup("hugepagesz=", hugepage_setup_sz); > > +static int __init hugetlb_default_size_setup(char *str) > +{ > + unsigned long long size; > + > + size = memparse(str, &str); > + > + if (add_huge_page_size(size) != 0) { > + hugetlb_bad_size(); > + pr_err("Invalid powerpc default huge page size specified(%llu)\n", size); > + } > + > + return 1; > +} > +__setup("default_hugepagesz=", hugetlb_default_size_setup); > + this means we don't core the core function hugetlb_default_setup(). Hence the value default_hstate_size = 0 which means different value for default_hstate_idx. We use that for hugetlbfs mount. > struct kmem_cache *hugepte_cache; > static int __init hugetlbpage_init(void) > { > -- > 1.8.3.1