Subject: Re: [PATCH] xen: selfballoon: remove unnecessary static in
 frontswap_selfshrink()
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20170704183404.GA13813@embeddedgus>
From: Juergen Gross <jgross@suse.com>
Message-ID: <49a2e01f-7f29-6e29-c5d4-6431218a07f1@suse.com>
Date: Fri, 21 Jul 2017 09:36:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170704183404.GA13813@embeddedgus>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1192
Lines: 50

On 04/07/17 20:34, Gustavo A. R. Silva wrote:
> Remove unnecessary static on local variables last_frontswap_pages and
> tgt_frontswap_pages. Such variables are initialized before being used,
> on every execution path throughout the function. The statics have no
> benefit and, removing them reduce the code size.
> 
> This issue was detected using Coccinelle and the following semantic patch:
> 
> @bad exists@
> position p;
> identifier x;
> type T;
> @@
> 
> static T x@p;
> ...
> x = <+...x...+>
> 
> @@
> identifier x;
> expression e;
> type T;
> position p != bad.p;
> @@
> 
> -static
>  T x@p;
>  ... when != x
>      when strict
> ?x = e;
> 
> You can see a significant difference in the code size after executing
> the size command, before and after the code change:
> 
> before:
>    text	   data	    bss	    dec	    hex	filename
>    5633	   3452	    384	   9469	   24fd	drivers/xen/xen-selfballoon.o
> 
> after:
>    text	   data	    bss	    dec	    hex	filename
>    5576	   3308	    256	   9140	   23b4	drivers/xen/xen-selfballoon.o
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Sorry for late answer,

Juergen