From: Heiko Stuebner <heiko@sntech.de>
To: David Wu <david.wu@rock-chips.com>
Cc: linus.walleij@linaro.org, huangtao@rock-chips.com,
        dianders@chromium.org, linux-rockchip@lists.infradead.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: rockchip: Use common interface for recalced iomux
Date: Fri, 21 Jul 2017 11:35:23 +0200
Message-ID: <2301545.dlea0HVRYo@phil>
User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; )
In-Reply-To: <1500618435-15092-2-git-send-email-david.wu@rock-chips.com>
References: <1500618435-15092-1-git-send-email-david.wu@rock-chips.com> <1500618435-15092-2-git-send-email-david.wu@rock-chips.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 959
Lines: 26

Am Freitag, 21. Juli 2017, 14:27:14 CEST schrieb David Wu:
> The other Socs also need the feature of recalced iomux, so
> make it as a common interface like iomux route feature.
> 
> Signed-off-by: David Wu <david.wu@rock-chips.com>
> ---
>  drivers/pinctrl/pinctrl-rockchip.c | 89 +++++++++++++++++++++-----------------
>  1 file changed, 50 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index e831647..fd4e491 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -76,7 +76,6 @@ enum rockchip_pinctrl_type {
>  #define IOMUX_SOURCE_PMU	BIT(2)
>  #define IOMUX_UNROUTED		BIT(3)
>  #define IOMUX_WIDTH_3BIT	BIT(4)
> -#define IOMUX_RECALCED		BIT(5)

very cool to see this flag go away and simply calculating the affected
bits is obviously a way nicer solution.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Thanks for that cleanup
Heiko