Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750961AbdGUKb4 (ORCPT ); Fri, 21 Jul 2017 06:31:56 -0400 Received: from mga06.intel.com ([134.134.136.31]:8888 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbdGUKby (ORCPT ); Fri, 21 Jul 2017 06:31:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,389,1496127600"; d="asc'?scan'208";a="127702892" From: Felipe Balbi To: Lu Baolu , Mathias Nyman , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Lu Baolu Subject: Re: [PATCH 2/3] usb: xhci: Add DbC support in xHCI driver In-Reply-To: <1500627169-27116-3-git-send-email-baolu.lu@linux.intel.com> References: <1500627169-27116-1-git-send-email-baolu.lu@linux.intel.com> <1500627169-27116-3-git-send-email-baolu.lu@linux.intel.com> Date: Fri, 21 Jul 2017 13:31:43 +0300 Message-ID: <87pocu3wts.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1542 Lines: 48 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Lu Baolu writes: > +static void xhci_dbc_stop(struct xhci_hcd *xhci) > +{ > + struct xhci_dbc *dbc =3D xhci->dbc; > + > + WARN_ON(!dbc); > + > + cancel_delayed_work_sync(&dbc->event_work); > + > + if (dbc->gs_port_num !=3D GSPORT_INVAL) { > + gserial_disconnect(&dbc->gs_port); > + gserial_free_line(dbc->gs_port_num); why are you tying host stack to the gadget framework? With this, you're forcing every single PC in the world to compile the gadget framework, that's a bit much don't you think? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAllx2A8ACgkQzL64meEa mQaH8Q/+Pd/9mO7eZFzhKVkWTjEkUusYSDPYSUH9PTCY6RaPO7U43rAcZHNRYr7D f8Y8p9QoW5LquPoxq+dxQprRBNVmCyFEkpFHJaZGnAo0ZQ/qgr7WT64OrNDBqsXd 7Ji2H4R6CXTKg0BP4aQSlArBNXqm4i+GZ/D/24YH/zG22yklDglIFaBEIFF7z8mB wGnj2wmxJnUh8/+wOIgsNVL5Clw6ntTs9vDEKbxCXwvmxgLVxunc6rMe0puwdyFT nczVmD78Hdulb1Ubidg8EJW4Cd0f1ypDvc/1GJDA7Pcj5wsnr84jR/aHFrop/XCi 6X7x3+QSzurcEKSBsbVCGTCZeiGv8FxjD1O9Ve8nEUaqgUdy/CJ8OqA2O9gI3Hr6 RctNd4w0Epj56+g8+gYFSYcJUzi1COlOtDT7gJc5uqRNrkf3HEiA1BwNRwDjQPtQ p0OcpQsbX5sT6vxz6ZOrCOmdT39yQP/Hrrto1GJ8b8YS70Cm/CfGi8W0arygleWF 41dHD77lrRqXF09LF2xUG4fZKIqApysk6mMBNujafz7sENIdP0+tHMF/MpjMHvTN DCXjUnoxyumV/Q6eVvrcA3eoKtZZv2vwkdVekggkDU+a+wlMxdB/cDADV2LUE9NO WXXvD1mUVEKPAl8GqfR/OLut5gcYk//btvnsJHKL0FtIT8ekf0Y= =psKe -----END PGP SIGNATURE----- --=-=-=--