Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753960AbdGULVi (ORCPT ); Fri, 21 Jul 2017 07:21:38 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33449 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbdGULVg (ORCPT ); Fri, 21 Jul 2017 07:21:36 -0400 Date: Fri, 21 Jul 2017 13:21:34 +0200 From: Pavel Machek To: Enric Balletbo i Serra Cc: Thierry Reding , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Rob Herring , Richard Purdie , Jacek Anaszewski , Heiko Stuebner , linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, groeck@chromium.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v4 3/5] pwm-backlight: add support for PWM delays proprieties. Message-ID: <20170721112134.GA10340@amd> References: <20170721104813.5389-1-enric.balletbo@collabora.com> <20170721104813.5389-3-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FCuugMFkClbJLl1L" Content-Disposition: inline In-Reply-To: <20170721104813.5389-3-enric.balletbo@collabora.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 41 --FCuugMFkClbJLl1L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2017-07-21 12:48:11, Enric Balletbo i Serra wrote: > Some panels (i.e. N116BGE-L41), in their power sequence specifications, > request a delay between set the PWM signal and enable the backlight and > between clear the PWM signal and disable the backlight. Add support for > the new post-pwm-on-delay-ms and pwm-off-delay-ms proprieties to meet > the timings. >=20 > Signed-off-by: Enric Balletbo i Serra For 3-5: Acked-by: Pavel Machek I guess you probably meant "properties" and I guess english could be improved in the comments, but... this is good enough and not worth more iterations. --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --FCuugMFkClbJLl1L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAllx474ACgkQMOfwapXb+vIlQwCfQXHVlqRrjnka9TAeEzYqRWI+ SywAn00Bl5ZFSAHZ0EVm1nUU+SDHlzpF =0ZKG -----END PGP SIGNATURE----- --FCuugMFkClbJLl1L--