DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 219F022B4E
Date: Fri, 21 Jul 2017 08:24:20 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Taeung Song <treeze.taeung@gmail.com>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung@kernel.org>,
        Milian Wolff <milian.wolff@kdab.com>, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v3 3/9] perf annotate: Fix wrong --show-total-period
 option showing number of samples
Message-ID: <20170721112420.GE4134@kernel.org>
References: <1500500215-16646-1-git-send-email-treeze.taeung@gmail.com>
 <20170720191934.GD4134@kernel.org>
 <51c3c55a-d43d-427f-53fb-56b3ab275dd9@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51c3c55a-d43d-427f-53fb-56b3ab275dd9@gmail.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1118
Lines: 25

Em Fri, Jul 21, 2017 at 06:41:29PM +0900, Taeung Song escreveu:
> On 07/21/2017 04:19 AM, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Jul 20, 2017 at 06:36:55AM +0900, Taeung Song escreveu:
> > > Currently the --show-total-period option of perf-annotate
> > > is different from perf-report's.

> > > For example, perf-report ordinarily shows period and number of samples.

> > >   # Overhead       Samples        Period  Command  Shared Object   Symbol
> > >        9.83%           102      84813704  test     test            [.] knapsack

> > But this is not what this patch does, it is still doing too many things,
> > it should first add sample to those function signatures, leaving the
> > "meat" to a followup patch, where we will not be distracted with
> > infrastructure needed to do what you describe in the changelog.

> > I'm doing it here this time, please look at the result, later.
 
> ok, I'm waiting for it.
> And if you give me some sketchy code, that's fine.
> If you do, I'll remake this patch based on the result. :)

Take a look at the acme/tmp_perf/core, that is where I got yesterday.

- Arnaldo