Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753989AbdGULik (ORCPT ); Fri, 21 Jul 2017 07:38:40 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:45799 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753947AbdGULih (ORCPT ); Fri, 21 Jul 2017 07:38:37 -0400 Subject: Re: [PATCH] pci: add missing __iomem cast To: Christoph Hellwig , Carlos Palminha References: <20170719120535.26350-1-palminha@synopsys.com> <20170720080742.GA22116@infradead.org> CC: , , , From: Carlos Palminha Message-ID: <84660edf-3a19-0400-4fa7-8f26ae5e4218@synopsys.com> Date: Fri, 21 Jul 2017 12:38:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20170720080742.GA22116@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.25.98] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 665 Lines: 20 Hi Christoph, Looking deep into to this, i think there is no need to use phy_to_virts since pdev->rom is already a physical address. That's what pci_platform_rom should return, right?! I'll probably send a new patch removing the usage of phys_to_virt. Regards, C.Palminha On 20-07-2017 09:07, Christoph Hellwig wrote: > On Wed, Jul 19, 2017 at 01:05:35PM +0100, Carlos Palminha wrote: >> Add missing __iomem annotation to fix sparse warning: >> - incorrect type in return expression (different address spaces) > > How is this going to shut up sparse without a __force? > > And once you add the __force please also add a comment explaining > why it's safe. >