DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0270D5473D
Date: Fri, 21 Jul 2017 20:35:45 +0800
From: Baoquan He <bhe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, keescook@chromium.org,
        matt@codeblueprint.co.uk, tglx@linutronix.de, hpa@zytor.com,
        izumi.taku@jp.fujitsu.com, fanc.fnst@cn.fujitsu.com,
        thgarnie@google.com, n-horiguchi@ah.jp.nec.com
Subject: Re: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be
 randomized in mirror regions
Message-ID: <20170721123545.GJ2344@x1>
References: <1500542189-15779-1-git-send-email-bhe@redhat.com>
 <20170721103347.ticzuwed3ljys6kf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170721103347.ticzuwed3ljys6kf@gmail.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1313
Lines: 33

On 07/21/17 at 12:33pm, Ingo Molnar wrote:
> 
> * Baoquan He <bhe@redhat.com> wrote:
> 
> > Kernel text may be located in non-mirror regions (movable zone) when both
> > address range mirroring feature and KASLR are enabled.
> > 
> > The address range mirroring feature arranges such mirror region into
> > normal zone and other region into movable zone in order to locate
> > kernel code and data in mirror region. The physical memory region
> > whose descriptors in EFI memory map has EFI_MEMORY_MORE_RELIABLE
> > attribute (bit: 16) are mirrored.
> > 
> > If efi is detected, iterate efi memory map and pick the mirror region to
> > process for adding candidate of randomization slot. If efi is disabled
> > or no mirror region found, still process e820 memory map.
> 
> Please read your own changelogs and capitalize 'EFI' consistently!
> 
> Also, what is unclear to me after reading this changelog, what does this patch 
> actually achieve, relative to existing behavior?
> 
> It would be helpful if it was structured like this:
> 
>     Previous behavior was that the kernel would ...
> 
>     This patch changes the old behavior so that the kernel now ...

Sure, I will check the patch log and change all 'efi' to 'EFI'. And
rewrite the log according to the suggested format. Thanks a lot!

Thanks
Baoquan