Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbdGUMyj (ORCPT ); Fri, 21 Jul 2017 08:54:39 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:60117 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750802AbdGUMyi (ORCPT ); Fri, 21 Jul 2017 08:54:38 -0400 From: Ivan Mikhaylov To: Ian Campbell Cc: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/44x/fsp2: correct dtb reg property for /sdhci@020c0000 Date: Fri, 21 Jul 2017 15:54:27 +0300 X-Mailer: git-send-email 2.10.1 (Apple Git-78) In-Reply-To: <20170715090302.23105-1-ijc@hellion.org.uk> References: <20170715090302.23105-1-ijc@hellion.org.uk> X-MIMETrack: Itemize by SMTP Server on D06ML001/06/M/IBM(Release 9.0.1FP8HF179 | April 20, 2017) at 21/07/2017 13:54:30, Serialize by Router on D06ML001/06/M/IBM(Release 9.0.1FP8HF179 | April 20, 2017) at 21/07/2017 13:54:30, Serialize complete at 21/07/2017 13:54:30 X-TNEFEvaluated: 1 X-TM-AS-GCONF: 00 x-cbid: 17072112-0040-0000-0000-000003C5D017 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17072112-0041-0000-0000-000025C22983 Message-Id: <20170721125427.77668-1-ivan@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-07-21_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1707210203 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 20 Hi Ian, >Building the split device-tree tree[0] highlighted that upstream commit >9eec6cb142bd ("powerpc/44x/fsp2: Add device tree for FSP2 board") introduced >this warning when building the device tree: > >$ make CROSS_COMPILE=powerpc-linux-gnu- ARCH=powerpc fsp2.dtb > CHK scripts/mod/devicetable-offsets.h > DTC arch/powerpc/boot/fsp2.dtb >arch/powerpc/boot/fsp2.dtb: Warning (reg_format): "reg" property in /sdhci@020c0000 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) > >This commit adds the second adress cell as zeroes to resolve the warning. Note: >I have no access to or information about this platform so this is purely a >guess as to the fix. An alternative would be to adjust #address-cells, but >whether that is correct or not depends on the platform. Yes, this problem exists on this tag but it is already fixed and waiting for review by this https://patchwork.kernel.org/patch/9819379/ . You can check it if you want, anyways it will go to powerpc next branch first. Thank you.