Date: Sat, 21 Jun 2003 10:05:43 -0700 (PDT)
From: Linus Torvalds <torvalds@transmeta.com>
To: Arnd Bergmann <arnd@arndb.de>
cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [SPARSE] increase MAXNEST constant
In-Reply-To: <200306211353.43512.arnd@arndb.de>
Message-ID: <Pine.LNX.4.44.0306211004180.2384-100000@home.transmeta.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 873
Lines: 25


On Sat, 21 Jun 2003, Arnd Bergmann wrote:
>
> The MAXNEST constant in sparse is currently too small for
> checking most of the kernel files.

Thanks, right you are. I fixed it a bit differently, in particular it 
doesn't need an "int", it really needs just one bit per level, but I left 
it at "char" instead.

>				 The deepest nesting
> I found in the kernel is 25, so MAXNEST=32 should probably
> be sufficient. It would be nice to check overruns here,
> but I did not know where to best do it.

I did that too (and I made the size of the nesting be 256, since changing 
it to a char means that it's fairly small).

		Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/