Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753665AbdGUN1t (ORCPT ); Fri, 21 Jul 2017 09:27:49 -0400 Received: from mx2.suse.de ([195.135.220.15]:55111 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751643AbdGUN1r (ORCPT ); Fri, 21 Jul 2017 09:27:47 -0400 Date: Fri, 21 Jul 2017 15:27:31 +0200 From: Borislav Petkov To: Punit Agrawal Cc: linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com, sudeep.holla@arm.com, linux-acpi@vger.kernel.org, "Rafael J. Wysocki" Subject: Re: [PATCH 3/4] ACPI / APEI: Drop uninformative messages during boot Message-ID: <20170721132731.GA5041@nazgul.tnic> References: <20170720110402.15313-1-punit.agrawal@arm.com> <20170720110402.15313-4-punit.agrawal@arm.com> <20170720111732.GC18515@nazgul.tnic> <87d18vmgv6.fsf@e105922-lin.cambridge.arm.com> <20170720135446.GA20641@nazgul.tnic> <87shhrknes.fsf@e105922-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87shhrknes.fsf@e105922-lin.cambridge.arm.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 545 Lines: 18 On Thu, Jul 20, 2017 at 06:50:51PM +0100, Punit Agrawal wrote: > "Firmware does not support APEI firmware first mode" > > Thoughts? I guess the simplest would be to add a third state to that hest_disable to denote "HEST table not found" and then exit ghes_init() early, based on checking it. Otherwise ghes_init() inits a bunch of things which you probably don't want on a platform which doesn't support APEI. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --