Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753611AbdGUNfN (ORCPT ); Fri, 21 Jul 2017 09:35:13 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:35151 "EHLO mail-qk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753424AbdGUNfL (ORCPT ); Fri, 21 Jul 2017 09:35:11 -0400 MIME-Version: 1.0 In-Reply-To: References: <1500636105-11520-1-git-send-email-hayashi.kunihiko@socionext.com> From: Masami Hiramatsu Date: Fri, 21 Jul 2017 22:34:49 +0900 Message-ID: Subject: Re: [PATCH v5 0/2] add UniPhier thermal support To: Masahiro Yamada Cc: Kunihiko Hayashi , rui.zhang@intel.com, Eduardo Valentin , linux-pm@vger.kernel.org, linux-arm-kernel , Linux Kernel Mailing List , Rob Herring , Mark Rutland , Jassi Brar Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2236 Lines: 74 Hello, 2017-07-21 22:24 GMT+09:00 Masahiro Yamada : > 2017-07-21 20:21 GMT+09:00 Kunihiko Hayashi : >> This series adds support for CPU temperature monitor modules implemented >> on UniPhier LD20 and PXs2 SoCs. This driver supports temperature monitoring >> and alert function on the module. >> >> Changes in v4: >> - fix warnings from sparse by replacing u32 with __be32 > > Nit. > > Your subject prefix indicates this patch is v5. > > Do you mean "Changes in v5" or "Changes since v4" ? I've checked all previous series and it seems to mean "Changes from vN". Thanks, > > > > > > >> Changes in v3: >> - remove TMOD_MASK and use TMOD_WIDTH representing the bit width of TMOD >> >> Changes in v2: >> - add nsleep after starting and stopping PVT >> - replace temperature calculation with sign_extend32() >> >> Changes in v1: >> - separate dts from this patchset as another patchset >> - remove 'reg' description on the dt-bindings document >> - fix the order of calling initialization functions >> - replace mask bits to use GENMASK >> - fix calculation of temperature because of not considering a negative value >> - use devm_request_threaded_irq() instead of devm_request_irq() and >> separate a thread function from the interrupt handler >> - add dependency to Kconfig >> - set 120C to CRITICAL_TEMP_LIMIT as maximum temperature >> - shrink each line of parameters to save the number of lines >> - improve some comments and copyright description >> >> Kunihiko Hayashi (2): >> dt-bindings: thermal: add binding documentation for UniPhier thermal >> monitor >> thermal: uniphier: add UniPhier thermal driver >> >> .../bindings/thermal/uniphier-thermal.txt | 64 ++++ >> drivers/thermal/Kconfig | 8 + >> drivers/thermal/Makefile | 1 + >> drivers/thermal/uniphier_thermal.c | 386 +++++++++++++++++++++ >> 4 files changed, 459 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/thermal/uniphier-thermal.txt >> create mode 100644 drivers/thermal/uniphier_thermal.c >> >> -- >> 2.7.4 >> > > > > -- > Best Regards > Masahiro Yamada -- Masami Hiramatsu