Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754105AbdGUQri (ORCPT ); Fri, 21 Jul 2017 12:47:38 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:46842 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbdGUQrh (ORCPT ); Fri, 21 Jul 2017 12:47:37 -0400 Subject: Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver To: Greg KH Cc: ulf.hansson@linaro.org, linus.walleij@linaro.org, shawn.lin@rock-chips.com, adrian.hunter@intel.com, baolin.wang@linaro.org, hdegoede@redhat.com, maxime.ripard@free-electrons.com, thomas.petazzoni@free-electrons.com, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, devel@driverdev.osuosl.org, icenowy@aosc.xyz, wens@csie.org References: <20170721143502.1991-1-quentin.schulz@free-electrons.com> <20170721143502.1991-2-quentin.schulz@free-electrons.com> <20170721150133.GA18198@kroah.com> From: Quentin Schulz Message-ID: Date: Fri, 21 Jul 2017 18:47:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170721150133.GA18198@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2071 Lines: 58 Hi Greg, On 21/07/2017 17:01, Greg KH wrote: > On Fri, Jul 21, 2017 at 04:35:01PM +0200, Quentin Schulz wrote: >> The Espressif ESP8089 WiFi chips can be often found in cheap tablets. >> There is one in A23 Polaroid tablets for example. >> >> The chip is often embedded as an eMMC SDIO device. >> >> The code was taken from an out-of-tree repository and has seen a first >> pass in the cleanup process. >> >> At the moment, there is no publicly available datasheet for this chip. >> >> Cc: Hans de Goede >> Cc: Icenowy Zheng >> Signed-off-by: Quentin Schulz > > Staging drivers need a TODO file that lists what has to be done to the > code to get it out of staging. Why not just take a day or so and fix up > the remaining issues and get it into the "real" part of the kernel > correctly? > OK, I'll work on a TODO list. Is there anything else I should know about staging drivers so I can address everything at the same time? >From a driver that has already been cleaned up a bit by Icenowy and Hans, it took me between 10 and 15 working days to this step, which I estimate to be around 50% of total clean up (and we're only speaking about coding style and dead code mainly, nothing about a bit of code review, code robustness...). I find the code not really easy to follow (might be because I'm a beginner in the subsystem as well). I might not be the most efficient person in cleaning up drivers but I'm pretty sure this isn't a one day cleanup. (Would be happy to be proven otherwise :) ), else I would have done it as you suggest. > Also, staging drivers have to be "stand-alone", I can't take stuff that > requires core changes only for one staging driver. > Yes, I didn't expect the first version to go through, the goal was to revive the discussion on this core patch as there was a consensus that the requested feature was needed. Thanks, Quentin > thanks, > > greg k-h > -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com