Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754493AbdGUQxt convert rfc822-to-8bit (ORCPT ); Fri, 21 Jul 2017 12:53:49 -0400 Received: from coyote.holtmann.net ([212.227.132.17]:58823 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbdGUQxA (ORCPT ); Fri, 21 Jul 2017 12:53:00 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver From: Marcel Holtmann In-Reply-To: Date: Fri, 21 Jul 2017 18:52:56 +0200 Cc: Greg KH , Ulf Hansson , Linus Walleij , shawn.lin@rock-chips.com, adrian.hunter@intel.com, baolin.wang@linaro.org, Hans de Goede , maxime.ripard@free-electrons.com, thomas.petazzoni@free-electrons.com, kernel list , linux-mmc@vger.kernel.org, devel@driverdev.osuosl.org, icenowy@aosc.xyz, wens@csie.org Content-Transfer-Encoding: 8BIT Message-Id: <34C896A9-0FFE-4174-8E08-A07A12C4A7ED@holtmann.org> References: <20170721143502.1991-1-quentin.schulz@free-electrons.com> <20170721143502.1991-2-quentin.schulz@free-electrons.com> <20170721150133.GA18198@kroah.com> To: Quentin Schulz X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1800 Lines: 41 Hi Quentin, >>> The Espressif ESP8089 WiFi chips can be often found in cheap tablets. >>> There is one in A23 Polaroid tablets for example. >>> >>> The chip is often embedded as an eMMC SDIO device. >>> >>> The code was taken from an out-of-tree repository and has seen a first >>> pass in the cleanup process. >>> >>> At the moment, there is no publicly available datasheet for this chip. >>> >>> Cc: Hans de Goede >>> Cc: Icenowy Zheng >>> Signed-off-by: Quentin Schulz >> >> Staging drivers need a TODO file that lists what has to be done to the >> code to get it out of staging. Why not just take a day or so and fix up >> the remaining issues and get it into the "real" part of the kernel >> correctly? >> > > OK, I'll work on a TODO list. Is there anything else I should know about > staging drivers so I can address everything at the same time? > > From a driver that has already been cleaned up a bit by Icenowy and > Hans, it took me between 10 and 15 working days to this step, which I > estimate to be around 50% of total clean up (and we're only speaking > about coding style and dead code mainly, nothing about a bit of code > review, code robustness...). I find the code not really easy to follow > (might be because I'm a beginner in the subsystem as well). > > I might not be the most efficient person in cleaning up drivers but I'm > pretty sure this isn't a one day cleanup. (Would be happy to be proven > otherwise :) ), else I would have done it as you suggest. even if it takes you 1 month to clean it up, get it reviewed on linux-wireless and target wireless-drivers instead of staging. When I had a brief a look at your patch, it didn't look like staging material to me. Regards Marcel