Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754583AbdGURGU (ORCPT ); Fri, 21 Jul 2017 13:06:20 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:47110 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752780AbdGURF2 (ORCPT ); Fri, 21 Jul 2017 13:05:28 -0400 Subject: Re: [PATCH 1/2] staging: net: wireless: add ESP8089 WiFi driver To: Marcel Holtmann Cc: Greg KH , Ulf Hansson , Linus Walleij , shawn.lin@rock-chips.com, adrian.hunter@intel.com, baolin.wang@linaro.org, Hans de Goede , maxime.ripard@free-electrons.com, thomas.petazzoni@free-electrons.com, kernel list , linux-mmc@vger.kernel.org, devel@driverdev.osuosl.org, icenowy@aosc.xyz, wens@csie.org References: <20170721143502.1991-1-quentin.schulz@free-electrons.com> <20170721143502.1991-2-quentin.schulz@free-electrons.com> <20170721150133.GA18198@kroah.com> <34C896A9-0FFE-4174-8E08-A07A12C4A7ED@holtmann.org> From: Quentin Schulz Message-ID: <37e6e8f9-8f36-cb78-276d-01f4656c6e47@free-electrons.com> Date: Fri, 21 Jul 2017 19:05:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <34C896A9-0FFE-4174-8E08-A07A12C4A7ED@holtmann.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2681 Lines: 68 Hi Marcel, On 21/07/2017 18:52, Marcel Holtmann wrote: > Hi Quentin, > >>>> The Espressif ESP8089 WiFi chips can be often found in cheap tablets. >>>> There is one in A23 Polaroid tablets for example. >>>> >>>> The chip is often embedded as an eMMC SDIO device. >>>> >>>> The code was taken from an out-of-tree repository and has seen a first >>>> pass in the cleanup process. >>>> >>>> At the moment, there is no publicly available datasheet for this chip. >>>> >>>> Cc: Hans de Goede >>>> Cc: Icenowy Zheng >>>> Signed-off-by: Quentin Schulz >>> >>> Staging drivers need a TODO file that lists what has to be done to the >>> code to get it out of staging. Why not just take a day or so and fix up >>> the remaining issues and get it into the "real" part of the kernel >>> correctly? >>> >> >> OK, I'll work on a TODO list. Is there anything else I should know about >> staging drivers so I can address everything at the same time? >> >> From a driver that has already been cleaned up a bit by Icenowy and >> Hans, it took me between 10 and 15 working days to this step, which I >> estimate to be around 50% of total clean up (and we're only speaking >> about coding style and dead code mainly, nothing about a bit of code >> review, code robustness...). I find the code not really easy to follow >> (might be because I'm a beginner in the subsystem as well). >> >> I might not be the most efficient person in cleaning up drivers but I'm >> pretty sure this isn't a one day cleanup. (Would be happy to be proven >> otherwise :) ), else I would have done it as you suggest. > > even if it takes you 1 month to clean it up, get it reviewed on linux-wireless and target wireless-drivers instead of staging. When I had a brief a look at your patch, it didn't look like staging material to me. > We don't have a client supporting this effort and I don't think the company I work for would support this effort (maybe it would, but definitely spread over a long long period), so we're talking about 10-15 working days spread over my free time/week-end, that isn't for in one month :) I could use help for sure on this driver, that's why I posted it in staging. I've done the cleanup on a per-file basis so maybe you looked at one of the cleaned up files? Just to be sure, you're telling me that I should post it as is on linux-wireless and then work with the reviews? Or are you telling me to take "1 month to clean it up" and then post it on linux-wireless? Thanks, Quentin > Regards > > Marcel > -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com