Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754627AbdGURKV (ORCPT ); Fri, 21 Jul 2017 13:10:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60776 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752091AbdGURKB (ORCPT ); Fri, 21 Jul 2017 13:10:01 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0F09B609C6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Subject: Re: [PATCH v1 6/6] usb: dwc3: core: Notify USB3 PHY as well for DRD modes To: Manu Gautam , Kishon Vijay Abraham I , Felipe Balbi Cc: linux-arm-msm@vger.kernel.org, Greg Kroah-Hartman , "open list:DESIGNWARE USB3 DRD IP DRIVER" , open list References: <1500634921-25914-1-git-send-email-mgautam@codeaurora.org> <1500634921-25914-7-git-send-email-mgautam@codeaurora.org> From: Stephen Boyd Message-ID: <82ac9131-56bb-ea17-4afd-d56649320302@codeaurora.org> Date: Fri, 21 Jul 2017 10:09:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1500634921-25914-7-git-send-email-mgautam@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 16 On 07/21/2017 04:02 AM, Manu Gautam wrote: > Driver currently notifies only USB3 PHY for mode change. > Extend this to USB3 PHY so that driver based on the mode > can release system resources - clocks, regulators etc. > and can even turn off PHY during runtime suspend. > > Signed-off-by: Manu Gautam This patch is confusing because you say "notify for usb3 phy", but then combine a change to remove the NULL pointer check on phy_set_mode() for the usb2 phy. Please describe everything that's happening in a patch in the commit text. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project