Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754584AbdGURif (ORCPT ); Fri, 21 Jul 2017 13:38:35 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:33317 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753905AbdGURh5 (ORCPT ); Fri, 21 Jul 2017 13:37:57 -0400 Date: Fri, 21 Jul 2017 19:37:53 +0200 From: Ingo Molnar To: Baoquan He Cc: linux-kernel@vger.kernel.org, x86@kernel.org, keescook@chromium.org, matt@codeblueprint.co.uk, tglx@linutronix.de, hpa@zytor.com, izumi.taku@jp.fujitsu.com, fanc.fnst@cn.fujitsu.com, thgarnie@google.com, n-horiguchi@ah.jp.nec.com Subject: Re: [PATCH v6 RESEND] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions Message-ID: <20170721173753.54mn7udl6byzq2yh@gmail.com> References: <1500542189-15779-1-git-send-email-bhe@redhat.com> <20170721103757.hc74czr3mfunrv6c@gmail.com> <20170721131956.GK2344@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170721131956.GK2344@x1> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 24 * Baoquan He wrote: > > > +static inline bool process_efi_entries(unsigned long minimum, > > > + unsigned long image_size) > > > > ugly linebreak again ... > > The whole line is more than 80. I break the line and use tab and space > to make it align with above 'unsigned long minimum'. Don't know why it > becomes messy in patch. Will check and try again. Then make the linebreak less ugly, or ignore the checkpatch warning! This commonly used pattern: static inline bool process_efi_entries(unsigned long minimum, unsigned long image_size) looks a lot better than the function parameter list broken in the middle. Thanks, Ingo