Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754857AbdGUUhQ (ORCPT ); Fri, 21 Jul 2017 16:37:16 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:43184 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754492AbdGUUhO (ORCPT ); Fri, 21 Jul 2017 16:37:14 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7D39160712 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 21 Jul 2017 13:37:12 -0700 From: Stephen Boyd To: Vladimir Zapolskiy Cc: Gabriel FERNANDEZ , Rob Herring , Mark Rutland , Russell King , Maxime Coquelin , Alexandre TORGUE , Michael Turquette , Nicolas Pitre , Arnd Bergmann , "daniel.thompson@linaro.org" , "andrea.merello@gmail.com" , "radoslaw.pietrzyk@gmail.com" , Lee Jones , Sylvain Lemieux , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-clk@vger.kernel.org" , Ludovic BARRE , Olivier BIDEAU , Amelie DELAUNAY , "gabriel.fernandez.st@gmail.com" , Arvind Yadav Subject: Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver Message-ID: <20170721203712.GH19878@codeaurora.org> References: <1500474344-9832-1-git-send-email-gabriel.fernandez@st.com> <1500474344-9832-4-git-send-email-gabriel.fernandez@st.com> <11c37627-a39b-7f2d-d0d4-af312eac8668@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1609 Lines: 41 On 07/20, Vladimir Zapolskiy wrote: > Hi Gabriel, > > On 07/20/2017 11:31 AM, Gabriel FERNANDEZ wrote: > > Hi Vladimir, > > > > > > On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: > >> Hello Gabriel, > >> > >> On 07/19/2017 05:25 PM, gabriel.fernandez@st.com wrote: > >>> From: Gabriel Fernandez > >>> + > >>> + rcc: rcc@58024400 { > >> 'rcc' as a generic device node name is awkward. > >> > >> I believe the main function of the device is clock controller (unlikely > >> a generic reset controller can be converted into a clock controller), > >> the locations of the document and device driver also indicate that > >> primarily it is a clock controller, so I suggest to replace device node > >> name with 'clock-controller' like below: > > I prefer to keep rcc node name, to be coherent with the other ST > > platforms (STM32F4/F7) > > the thing is, a device node name is expected to comply with ePAPR or > the devicetree specification, which says > > The name of a node should be somewhat generic, reflecting > the function of the device and not its precise programming model. > > If devicetree and CCF maintainers are fine with 'rcc', I won't object, > my role is just to emphasize the found issue and recommend to use another > and more common name 'clock-controller', it is a simple and fortunately > backward compatible change to other ST platforms as well. Yes. It should be generic so clock-controller or clock-reset-controller is appropriate here. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project